Skip to content

Commit be83771

Browse files
committed
Update diff
1 parent 53fad2d commit be83771

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

dev/diffs/3.4.2.diff

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ index 9ddb4abe98b..1bebe99f1cc 100644
249249
sql(
250250
"""
251251
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
252-
index f33432ddb6f..6160c8d241a 100644
252+
index f33432ddb6f..060f874ea72 100644
253253
--- a/sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
254254
+++ b/sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
255255
@@ -22,6 +22,7 @@ import org.scalatest.GivenWhenThen
@@ -270,7 +270,17 @@ index f33432ddb6f..6160c8d241a 100644
270270
case _ => Nil
271271
}
272272
}
273-
@@ -1238,7 +1242,8 @@ abstract class DynamicPartitionPruningSuiteBase
273+
@@ -1187,7 +1191,8 @@ abstract class DynamicPartitionPruningSuiteBase
274+
}
275+
}
276+
277+
- test("Make sure dynamic pruning works on uncorrelated queries") {
278+
+ test("Make sure dynamic pruning works on uncorrelated queries",
279+
+ IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
280+
withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "true") {
281+
val df = sql(
282+
"""
283+
@@ -1238,7 +1243,8 @@ abstract class DynamicPartitionPruningSuiteBase
274284
}
275285
}
276286

@@ -280,7 +290,7 @@ index f33432ddb6f..6160c8d241a 100644
280290
Given("dynamic pruning filter on the build side")
281291
withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "true") {
282292
val df = sql(
283-
@@ -1485,7 +1490,7 @@ abstract class DynamicPartitionPruningSuiteBase
293+
@@ -1485,7 +1491,7 @@ abstract class DynamicPartitionPruningSuiteBase
284294
}
285295

286296
test("SPARK-38148: Do not add dynamic partition pruning if there exists static partition " +
@@ -289,7 +299,7 @@ index f33432ddb6f..6160c8d241a 100644
289299
withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
290300
Seq(
291301
"f.store_id = 1" -> false,
292-
@@ -1729,6 +1734,8 @@ abstract class DynamicPartitionPruningV1Suite extends DynamicPartitionPruningDat
302+
@@ -1729,6 +1735,8 @@ abstract class DynamicPartitionPruningV1Suite extends DynamicPartitionPruningDat
293303
case s: BatchScanExec =>
294304
// we use f1 col for v2 tables due to schema pruning
295305
s.output.exists(_.exists(_.argString(maxFields = 100).contains("f1")))

0 commit comments

Comments
 (0)