Skip to content

Commit 21b9626

Browse files
authored
Improve documentation for calculate_prune_length method in SymmetricHashJoin (#8125)
* Minor: Improve the document format of JoinHashMap * Minor: Improve documentation for calculate_prune_length method * fix: method describe
1 parent bd4b3f4 commit 21b9626

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

datafusion/physical-plan/src/joins/symmetric_hash_join.rs

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -952,27 +952,17 @@ impl OneSideHashJoiner {
952952
Ok(())
953953
}
954954

955-
/// Prunes the internal buffer.
956-
///
957-
/// Argument `probe_batch` is used to update the intervals of the sorted
958-
/// filter expressions. The updated build interval determines the new length
959-
/// of the build side. If there are rows to prune, they are removed from the
960-
/// internal buffer.
955+
/// Calculate prune length.
961956
///
962957
/// # Arguments
963958
///
964-
/// * `schema` - The schema of the final output record batch
965-
/// * `probe_batch` - Incoming RecordBatch of the probe side.
959+
/// * `build_side_sorted_filter_expr` - Build side mutable sorted filter expression..
966960
/// * `probe_side_sorted_filter_expr` - Probe side mutable sorted filter expression.
967-
/// * `join_type` - The type of join (e.g. inner, left, right, etc.).
968-
/// * `column_indices` - A vector of column indices that specifies which columns from the
969-
/// build side should be included in the output.
970961
/// * `graph` - A mutable reference to the physical expression graph.
971962
///
972963
/// # Returns
973964
///
974-
/// If there are rows to prune, returns the pruned build side record batch wrapped in an `Ok` variant.
975-
/// Otherwise, returns `Ok(None)`.
965+
/// A Result object that contains the pruning length.
976966
pub(crate) fn calculate_prune_length_with_probe_batch(
977967
&mut self,
978968
build_side_sorted_filter_expr: &mut SortedFilterExpr,

0 commit comments

Comments
 (0)