Skip to content

Commit 3f6ff22

Browse files
authored
update cast (#8458)
1 parent ecb7c7d commit 3f6ff22

File tree

1 file changed

+2
-4
lines changed
  • datafusion/physical-expr/src/expressions

1 file changed

+2
-4
lines changed

datafusion/physical-expr/src/expressions/cast.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,7 @@ impl PhysicalExpr for CastExpr {
140140
let mut s = state;
141141
self.expr.hash(&mut s);
142142
self.cast_type.hash(&mut s);
143-
// Add `self.cast_options` when hash is available
144-
// https://github.com/apache/arrow-rs/pull/4395
143+
self.cast_options.hash(&mut s);
145144
}
146145

147146
/// A [`CastExpr`] preserves the ordering of its child.
@@ -157,8 +156,7 @@ impl PartialEq<dyn Any> for CastExpr {
157156
.map(|x| {
158157
self.expr.eq(&x.expr)
159158
&& self.cast_type == x.cast_type
160-
// TODO: Use https://github.com/apache/arrow-rs/issues/2966 when available
161-
&& self.cast_options.safe == x.cast_options.safe
159+
&& self.cast_options == x.cast_options
162160
})
163161
.unwrap_or(false)
164162
}

0 commit comments

Comments
 (0)