Migrate tests

Author: yyin-dev

datafusion/physical-expr/src/aggregate/variance.rs

@@ -257,7 +257,6 @@ impl Accumulator for VarianceAccumulator {
     }
 }
 
-// TODO (yyin): Move to aggregations.slt
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -285,24 +284,6 @@ mod tests {
         generic_test_op!(a, DataType::Float64, VariancePop, ScalarValue::from(2_f64))
     }
 
-    // #[test]
-    // fn variance_f64_3() -> Result<()> {
-    //     let a: ArrayRef =
-    //         Arc::new(Float64Array::from(vec![1_f64, 2_f64, 3_f64, 4_f64, 5_f64]));
-    //     generic_test_op!(a, DataType::Float64, Variance, ScalarValue::from(2.5_f64))
-    // }
-
-    // #[test]
-    // fn variance_f64_4() -> Result<()> {
-    //     let a: ArrayRef = Arc::new(Float64Array::from(vec![1.1_f64, 2_f64, 3_f64]));
-    //     generic_test_op!(
-    //         a,
-    //         DataType::Float64,
-    //         Variance,
-    //         ScalarValue::from(0.9033333333333333_f64)
-    //     )
-    // }
-
     #[test]
     fn variance_i32() -> Result<()> {
         let a: ArrayRef = Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5]));
@@ -323,23 +304,6 @@ mod tests {
         generic_test_op!(a, DataType::Float32, VariancePop, ScalarValue::from(2_f64))
     }
 
-    // #[test]
-    // fn test_variance_1_input() -> Result<()> {
-    //     let a: ArrayRef = Arc::new(Float64Array::from(vec![1_f64]));
-    //     let schema = Schema::new(vec![Field::new("a", DataType::Float64, false)]);
-    //     let batch = RecordBatch::try_new(Arc::new(schema.clone()), vec![a])?;
-
-    //     let agg = Arc::new(Variance::new(
-    //         col("a", &schema)?,
-    //         "bla".to_string(),
-    //         DataType::Float64,
-    //     ));
-    //     let actual = aggregate(&batch, agg).unwrap();
-    //     assert_eq!(actual, ScalarValue::Float64(None));
-
-    //     Ok(())
-    // }
-
     #[test]
     fn variance_i32_with_nulls() -> Result<()> {
         let a: ArrayRef = Arc::new(Int32Array::from(vec![
@@ -357,23 +321,6 @@ mod tests {
         )
     }
 
-    // #[test]
-    // fn variance_i32_all_nulls() -> Result<()> {
-    //     let a: ArrayRef = Arc::new(Int32Array::from(vec![None, None]));
-    //     let schema = Schema::new(vec![Field::new("a", DataType::Int32, true)]);
-    //     let batch = RecordBatch::try_new(Arc::new(schema.clone()), vec![a])?;
-
-    //     let agg = Arc::new(Variance::new(
-    //         col("a", &schema)?,
-    //         "bla".to_string(),
-    //         DataType::Float64,
-    //     ));
-    //     let actual = aggregate(&batch, agg).unwrap();
-    //     assert_eq!(actual, ScalarValue::Float64(None));
-
-    //     Ok(())
-    // }
-
     #[test]
     fn variance_f64_merge_1() -> Result<()> {
         let a = Arc::new(Float64Array::from(vec![1_f64, 2_f64, 3_f64]));

datafusion/sqllogictest/test_files/aggregate.slt

@@ -2338,6 +2338,54 @@ select covar_pop(c1, c2), arrow_typeof(covar_pop(c1, c2)) from t;
 statement ok
 drop table t;
 
+# variance_f64_1
+statement ok
+create table t (c double) as values (1), (2), (3), (4), (5);
+
+query RT
+select var(c), arrow_typeof(var(c)) from t;
+----
+2.5 Float64
+
+statement ok
+drop table t;
+
+# variance_f64_2
+statement ok
+create table t (c double) as values (1.1), (2), (3);
+
+query RT
+select var(c), arrow_typeof(var(c)) from t;
+----
+0.903333333333 Float64
+
+statement ok
+drop table t;
+
+# variance_1_input
+statement ok
+create table t (a double not null) as values (1);
+
+query RT
+select var(a), arrow_typeof(var(a)) from t;
+----
+NULL Float64
+
+statement ok
+drop table t;
+
+# variance_i32_all_nulls
+statement ok
+create table t (a int) as values (null), (null);
+
+query RT
+select var(a), arrow_typeof(var(a)) from t;
+----
+NULL Float64
+
+statement ok
+drop table t;
+
 # simple_mean
 query R
 select mean(c1) from test

datafusion/sqllogictest/test_files/order.slt

@@ -1131,4 +1131,4 @@ physical_plan
 01)SortPreservingMergeExec: [c@0 ASC NULLS LAST]
 02)--ProjectionExec: expr=[CAST(inc_col@0 > desc_col@1 AS Int32) as c]
 03)----RepartitionExec: partitioning=RoundRobinBatch(2), input_partitions=1
-04)------CsvExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/core/tests/data/window_1.csv]]}, projection=[inc_col, desc_col], output_orderings=[[inc_col@0 ASC NULLS LAST], [desc_col@1 DESC]], has_header=true
+04)------CsvExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/core/tests/data/window_1.csv]]}, projection=[inc_col, desc_col], output_orderings=[[inc_col@0 ASC NULLS LAST], [desc_col@1 DESC]], has_header=true

datafusion/sqllogictest/test_files/sort_merge_join.slt

@@ -344,6 +344,7 @@ t1 as (
     select 11 a, 13 b)
     select t1.* from t1 where exists (select 1 from t1 t2 where t2.a = t1.a and t2.b != t1.b)
 ) order by 1, 2;
+----
 
 query II
 select * from (

datafusion/sqllogictest/test_files/unnest.slt

@@ -65,7 +65,7 @@ select * from unnest(struct(1,2,3));
 ----
 1 2 3
 
-## Multiple unnest expression in from clause 
+## Multiple unnest expression in from clause
 query IIII
 select * from unnest(struct(1,2,3)),unnest([4,5,6]);
 ----
@@ -446,7 +446,7 @@ query error DataFusion error: type_coercion\ncaused by\nThis feature is not impl
 select sum(unnest(generate_series(1,10)));
 
 ## TODO: support unnest as a child expr
-query error DataFusion error: Internal error: unnest on struct can ony be applied at the root level of select expression 
+query error DataFusion error: Internal error: unnest on struct can ony be applied at the root level of select expression
 select arrow_typeof(unnest(column5)) from unnest_table;