Move Pruning into physical-optimizer crate
#13485
Conversation
| datafusion-expr = { workspace = true, default-features = true } | ||
| datafusion-functions-nested = { workspace = true } |
There was a problem hiding this comment.
Can you please move datafusion-functions-nested to dev-dependencies?
I also think we can avoid the dependency on datafusion-expr by changing
use datafusion_expr::Operator;to
use datafusion_expr_common::operator::Operator;|
|
||
| [dependencies] | ||
| arrow = { workspace = true } | ||
| arrow-array = { workspace = true } |
There was a problem hiding this comment.
If possible, can you avoid this explicit dependency? Whatever is used in arrow-array should be available in arrow and then we can keep the dependency chain simpler
| //! based on statistics (e.g. Parquet Row Groups) | ||
| //! | ||
| //! [`Expr`]: crate::prelude::Expr | ||
| use std::collections::HashSet; |
There was a problem hiding this comment.
datafusion-expr dependency is needed by //! [Expr]: crate::prelude::Expr, should we remove the comment to avoid introducing new dependencies? @alamb
There was a problem hiding this comment.
In other places, we have changed the link to docs.rs directly. So in this case, change the link to
https://docs.rs/datafusion/latest/datafusion/logical_expr/enum.Expr.html
| recursive = { workspace = true } | ||
|
|
||
| [dev-dependencies] | ||
| datafusion-expr = { workspace = true } |
3 participants
Which issue does this PR close?
part of #11502.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?