Skip to content

[branch-50] Backport: Fix docs.rs build: Replace auto_doc_cfg with doc_cfg #17890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2025
Merged

[branch-50] Backport: Fix docs.rs build: Replace auto_doc_cfg with doc_cfg #17890

merged 2 commits into from
Oct 3, 2025

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Oct 2, 2025 •
edited
Loading

Which issue does this PR close?

Closes #17889

Fixes an issue in building docs, which are broken in the 50.1.0 release.

Rationale for this change

Fixes docs build.

What changes are included in this PR?

Use doc_cfg instead of auto_doc_cfg.

Are these changes tested?

Yes, see original PR

Are there any user-facing changes?

No

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate catalog Related to the catalog crate common Related to common crate execution Related to the execution crate proto Related to proto crate functions Changes to functions implementation datasource Changes to the datasource crate ffi Changes to the ffi crate physical-plan Changes to the physical-plan crate spark labels Oct 2, 2025
@AdamGS AdamGS mentioned this pull request Oct 2, 2025
Closed
22 tasks
alamb
alamb approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AdamGS 🙏

FYI @mbrobbel

@alamb
Copy link
Contributor

alamb commented Oct 3, 2025

Updated to get changes from #17892

@alamb alamb merged commit 842d0e4 into apache:branch-50 Oct 3, 2025
28 checks passed
@alamb
Copy link
Contributor

alamb commented Oct 3, 2025

🚀 -- than you @AdamGS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

catalog Related to the catalog crate common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate execution Related to the execution crate ffi Changes to the ffi crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate spark sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdamGS @alamb @mbrobbel