Add Expr::Exists to represent EXISTS subquery expression
#2339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Apr 25, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me.
Very excited to see the PR 🚋 for subqueries leave the station, so to speak 👍
|
|
||
| let outer_query = LogicalPlanBuilder::from(bar) | ||
| .project(vec![col("a")])? | ||
| .filter(exists(subquery))? |
| // input: Arc::new(inputs[0].clone()), | ||
| // schema, | ||
| // })) | ||
| Err(DataFusionError::Plan("not implemented".to_string())) |
Contributor
There was a problem hiding this comment.
Suggested change
| Err(DataFusionError::Plan("not implemented".to_string())) | |
| Err(DataFusionError::Plan("subquery support is not full implemented yet".to_string())) |
Member
Author
There was a problem hiding this comment.
I have now implemented this section of code, although it is not exercised by any tests yet
datafusion/expr/src/expr_fn.rs
Outdated
| } | ||
|
|
||
| /// Create an EXISTS subquery expression | ||
| pub fn exists(subquery: LogicalPlan) -> Expr { |
Contributor
There was a problem hiding this comment.
I wonder if this function should also be added to the prelude: https://github.com/apache/arrow-datafusion/blob/b890190a6521ab1e572184dcf6ea0a5afb3a47af/datafusion/core/src/prelude.rs#L33-L40
datafusion/expr/src/expr_fn.rs
Outdated
| } | ||
|
|
||
| /// Create an EXISTS subquery expression | ||
| pub fn exists(subquery: LogicalPlan) -> Expr { |
Contributor
There was a problem hiding this comment.
Maybe this function could take an Arc<LogicalPlan> so if someone already has one they can reuse it rather than making a copy to pass in here
Co-authored-by: Andrew Lamb <[email protected]>
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2337 and is part of #2248
Rationale for this change
This is the first step towards supporting
EXISTSsubquery expressions. This work is partly based on work by @paveltiunov in cube-js@d14f0deWhat changes are included in this PR?
Expr::Exists(Subquery)expressionLogicalPlan::Subquery, although that wasn't strictly necessary just to supportEXISTSEXISTSusingLogicalPlanBuilderAre there any user-facing changes?
API change.