Fix: allow arbitrary exprs in VALUES clause #5813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
Apr 4, 2023
| .into_iter() | ||
| .map(|row| { | ||
| row.into_iter() | ||
| .map(|v| match v { |
Contributor
Author
There was a problem hiding this comment.
I don't know why this was special cased -- it works just fine with general Exprs
Contributor
Author
Contributor
Author
|
Thank you for the review @Jefffrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5802
Rationale for this change
I want to be able to
INTERVALconstants inVALUESclausesWhat changes are included in this PR?
Avoid special casing
VALUESin sql planner (I think the existing special case is a function of DataFusion limitations when it was first implemented)So I fixed a limitation by deleting code
Are these changes tested?
Yes, new tests are added
Are there any user-facing changes?
fewer errors