Skip to content

Minor: remove null in array-append and array-prepend #8901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Minor: remove null in array-append and array-prepend #8901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions datafusion/physical-expr/src/array_expressions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,12 +1031,6 @@ where
let res = match list_array.value_type() {
DataType::List(_) => concat_internal::<i32>(args)?,
DataType::LargeList(_) => concat_internal::<i64>(args)?,
DataType::Null => {
Copy link
Contributor

@alamb alamb Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳 👌

return make_array(&[
list_array.values().to_owned(),
element_array.to_owned(),
]);
}
data_type => {
return generic_append_and_prepend::<O>(
list_array,
Expand Down
6 changes: 3 additions & 3 deletions datafusion/sqllogictest/test_files/array.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1577,9 +1577,9 @@ select
query ????
select
array_append(arrow_cast(make_array(), 'LargeList(Null)'), 4),
array_append(make_array(), null),
Copy link
Contributor

@comphead comphead Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests without arrow-case looks valid for me, should we delete them?

Copy link
Contributor

@jayzhan211 jayzhan211 Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is arrow-case?

Copy link
Member Author

@Weijun-H Weijun-H Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe arrow-cast?

Copy link
Contributor

@comphead comphead Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, arrow-cast, no worries, I found we already have such cases in array.slt

array_append(make_array(1, null, 3), 4),
array_append(make_array(null, null), 1)
array_append(arrow_cast(make_array(), 'LargeList(Null)'), null),
array_append(arrow_cast(make_array(1, null, 3), 'LargeList(Int64)'), 4),
array_append(arrow_cast(make_array(null, null), 'LargeList(Null)'), 1)
;
----
[4] [] [1, , 3, 4] [, , 1]
Expand Down