Skip to content

Commit 1f1fdcf

Browse files
author
Steve Vaughan Jr
committed
Use final to protect immutable ConnectionId
Mark non-test fields as private and final, and add a missing accessor.
1 parent 168be14 commit 1f1fdcf

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1706,9 +1706,9 @@ private Connection getConnection(ConnectionId remoteId,
17061706
@InterfaceAudience.LimitedPrivate({"HDFS", "MapReduce"})
17071707
@InterfaceStability.Evolving
17081708
public static class ConnectionId {
1709-
InetSocketAddress address;
1710-
UserGroupInformation ticket;
1711-
final Class<?> protocol;
1709+
private final InetSocketAddress address;
1710+
private final UserGroupInformation ticket;
1711+
private final Class<?> protocol;
17121712
private static final int PRIME = 16777619;
17131713
private final int rpcTimeout;
17141714
private final int maxIdleTime; //connections will be culled if it was idle for

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ public <T> ProtocolProxy<T> getProxy(Class<T> protocol, long clientVersion,
323323
Client.ConnectionId connId, Configuration conf, SocketFactory factory)
324324
throws IOException {
325325
return getProxy(protocol, clientVersion, connId.getAddress(),
326-
connId.ticket, conf, factory, connId.getRpcTimeout(),
326+
connId.getTicket(), conf, factory, connId.getRpcTimeout(),
327327
connId.getRetryPolicy(), null, null);
328328
}
329329

0 commit comments

Comments
 (0)