review changes

Author: ahmarsuhail

hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Statistic.java

@@ -322,6 +322,10 @@ public enum Statistic {
       TYPE_COUNTER),
 
   /* Stream Reads */
+  STREAM_READ_ANALYTICS_OPENED(
+      StreamStatisticNames.STREAM_READ_ANALYTICS_OPENED,
+      "Total count of times an analytics input stream to object store data was opened",
+      TYPE_COUNTER),
   STREAM_READ_BYTES(
       StreamStatisticNames.STREAM_READ_BYTES,
       "Bytes read from an input stream in read() calls",

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractS3AMockTest.java

@@ -54,10 +54,11 @@ public abstract class AbstractS3AMockTest {
 
   protected S3AFileSystem fs;
   protected S3Client s3;
+  protected Configuration conf;
 
   @Before
   public void setup() throws Exception {
-    Configuration conf = createConfiguration();
+    conf = createConfiguration();
     fs = new S3AFileSystem();
     URI uri = URI.create(FS_S3A + "://" + BUCKET);
     // unset S3CSE property from config to avoid pathIOE.

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AAnalyticsAcceleratorStreamReading.java

@@ -140,8 +140,6 @@ public void testMalformedParquetFooter() throws IOException {
    * row group, which contains the column data for a subset of rows. A single parquet file
    * can contain multiple row groups, this allows for further parallelisation, as each row group
    * can be processed independently.
-   *
-    * @throws IOException any IO problem
    */
  @Test
  public void testMultiRowGroupParquet() throws Throwable {

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AUnbuffer.java

@@ -44,6 +44,8 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
+import static org.apache.hadoop.fs.s3a.S3ATestUtils.skipIfAnalyticsAcceleratorEnabled;
+
 /**
  * Uses mocks to check that the {@link ResponseInputStream<GetObjectResponse>} is
  * closed when {@link org.apache.hadoop.fs.CanUnbuffer#unbuffer} is called.
@@ -55,6 +57,8 @@ public class TestS3AUnbuffer extends AbstractS3AMockTest {
   @Test
   public void testUnbuffer() throws IOException {
     // Create mock ObjectMetadata for getFileStatus()
+    skipIfAnalyticsAcceleratorEnabled(conf,
+        "Analytics accelerator does not support unbuffer");
     Path path = new Path("/file");
     HeadObjectResponse objectMetadata = HeadObjectResponse.builder()
         .contentLength(1L)