Skip to content

Commit d545f9c

Browse files
JoshRosensteveloughran
authored andcommitted
HADOOP-16437 documentation typo fix: fs.s3a.experimental.input.fadvise
Fix fs.s3a.experimental.fadvise to fs.s3a.experimental.input.fadvise Contributed by: Josh Rosen
1 parent d5ef38b commit d545f9c

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

hadoop-common-project/hadoop-common/src/site/markdown/filesystem/fsdatainputstreambuilder.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ of `FileSystem`.
5454

5555
```java
5656
out = fs.openFile(path)
57-
.opt("fs.s3a.experimental.fadvise", "random")
57+
.opt("fs.s3a.experimental.input.fadvise", "random")
5858
.must("fs.s3a.readahead.range", 256 * 1024)
5959
.build()
6060
.get();

hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/performance.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ killer.
281281
`fs.s3a.threads.max` and `fs.s3a.connection.maximum`.
282282

283283
1. Make sure that the bucket is using `sequential` or `normal` fadvise seek policies,
284-
that is, `fs.s3a.experimental.fadvise` is not set to `random`
284+
that is, `fs.s3a.experimental.input.fadvise` is not set to `random`
285285

286286
1. Perform listings in parallel by setting `-numListstatusThreads`
287287
to a higher number. Make sure that `fs.s3a.connection.maximum`
@@ -314,7 +314,7 @@ the S3 bucket/shard.
314314
</property>
315315

316316
<property>
317-
<name>fs.s3a.experimental.fadvise</name>
317+
<name>fs.s3a.experimental.input.fadvise</name>
318318
<value>normal</value>
319319
</property>
320320

hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/troubleshooting_s3a.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1129,7 +1129,7 @@ shows that it is generally more efficient to abort the TCP connection and initia
11291129
a new one than read to the end of a large file.
11301130

11311131
Note: the threshold when data is read rather than the stream aborted can be tuned
1132-
by `fs.s3a.readahead.range`; seek policy in `fs.s3a.experimental.fadvise`.
1132+
by `fs.s3a.readahead.range`; seek policy in `fs.s3a.experimental.input.fadvise`.
11331133

11341134
### <a name="no_such_bucket"></a> `FileNotFoundException` Bucket does not exist.
11351135

0 commit comments

Comments
 (0)