Skip to content

Commit e9dea30

Browse files
author
Ashutosh Gupta
committed
addressing comments
1 parent fa10a07 commit e9dea30

File tree

5 files changed

+23
-11
lines changed

5 files changed

+23
-11
lines changed

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323

2424
import org.apache.hadoop.conf.Configuration;
2525

26-
import static org.junit.jupiter.api.Assertions.*;
27-
2826
import org.apache.hadoop.fs.FileSystem;
2927
import org.apache.hadoop.fs.FileUtil;
3028
import org.apache.hadoop.fs.Path;
@@ -35,6 +33,10 @@
3533
import org.junit.jupiter.api.Test;
3634
import org.junit.jupiter.api.Timeout;
3735

36+
import static org.junit.jupiter.api.Assertions.assertEquals;
37+
import static org.junit.jupiter.api.Assertions.assertFalse;
38+
import static org.junit.jupiter.api.Assertions.assertTrue;
39+
3840
public class TestJobClient {
3941

4042
final static String TEST_DIR = new File("target",
@@ -64,7 +66,7 @@ void testGetClusterStatusWithLocalJobRunner() throws Exception {
6466

6567
@Test
6668
@Timeout(10000)
67-
void testIsJobDirValid() throws IOException {
69+
public void testIsJobDirValid() throws IOException {
6870
Configuration conf = new Configuration();
6971
FileSystem fs = FileSystem.getLocal(conf);
7072
Path testDir = new Path(TEST_DIR);

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,14 @@
2020

2121
import java.io.IOException;
2222

23-
import org.apache.hadoop.conf.Configuration;
23+
import org.junit.jupiter.api.Test;
2424

25-
import static org.junit.jupiter.api.Assertions.assertNotNull;
25+
import org.apache.hadoop.conf.Configuration;
2626
import org.apache.hadoop.fs.FSDataOutputStream;
2727
import org.apache.hadoop.fs.FileSystem;
2828
import org.apache.hadoop.fs.Path;
29-
import org.junit.jupiter.api.Test;
29+
30+
import static org.junit.jupiter.api.Assertions.assertNotNull;
3031

3132
public class TestJobClientGetJob {
3233

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestMRWithDistributedCache.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
import org.junit.jupiter.api.Test;
3131
import org.junit.jupiter.api.Timeout;
3232

33-
import static org.junit.jupiter.api.Assertions.*;
34-
3533
import org.apache.hadoop.conf.Configuration;
3634
import org.apache.hadoop.filecache.DistributedCache;
3735
import org.apache.hadoop.fs.FSDataOutputStream;
@@ -52,6 +50,12 @@
5250
import org.slf4j.Logger;
5351
import org.slf4j.LoggerFactory;
5452

53+
import static org.junit.jupiter.api.Assertions.assertEquals;
54+
import static org.junit.jupiter.api.Assertions.assertFalse;
55+
import static org.junit.jupiter.api.Assertions.assertNotNull;
56+
import static org.junit.jupiter.api.Assertions.assertNull;
57+
import static org.junit.jupiter.api.Assertions.assertTrue;
58+
5559
/**
5660
* Tests the use of the
5761
* {@link org.apache.hadoop.mapreduce.filecache.DistributedCache} within the

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020
import org.apache.hadoop.util.StringUtils;
2121

2222
import static org.assertj.core.api.Assertions.assertThat;
23-
import static org.junit.jupiter.api.Assertions.*;
23+
import static org.junit.jupiter.api.Assertions.assertEquals;
24+
import static org.junit.jupiter.api.Assertions.assertNotNull;
25+
import static org.junit.jupiter.api.Assertions.fail;
2426
import static org.mockito.Mockito.mock;
2527
import static org.mockito.Mockito.when;
2628

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestIds.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,15 @@
1919

2020
package org.apache.hadoop.mapreduce.v2.api.records;
2121

22-
import static org.junit.jupiter.api.Assertions.*;
23-
2422
import org.apache.hadoop.mapreduce.v2.util.MRBuilderUtils;
2523
import org.apache.hadoop.yarn.api.records.ApplicationId;
2624
import org.junit.jupiter.api.Test;
2725

26+
import static org.junit.jupiter.api.Assertions.assertEquals;
27+
import static org.junit.jupiter.api.Assertions.assertFalse;
28+
import static org.junit.jupiter.api.Assertions.assertNotEquals;
29+
import static org.junit.jupiter.api.Assertions.assertTrue;
30+
2831
public class TestIds {
2932

3033
@Test

0 commit comments

Comments
 (0)