Findbug fixes

Author: bilaharith

hadoop-project/pom.xml

@@ -206,6 +206,7 @@
     <powermock.version>1.5.6</powermock.version>
     <solr.version>7.7.0</solr.version>
     <openssl-wildfly.version>1.0.7.Final</openssl-wildfly.version>
+    <hamcrest.version>1.3</hamcrest.version>
   </properties>
 
   <dependencyManagement>
@@ -1355,6 +1356,11 @@
         <artifactId>jsr305</artifactId>
         <version>3.0.2</version>
       </dependency>
+      <dependency> 
+        <groupId>com.google.code.findbugs</groupId> 
+        <artifactId>annotations</artifactId> 
+        <version>3.0.1</version> 
+      </dependency>
       <dependency>
         <groupId>javax.xml.bind</groupId>
         <artifactId>jaxb-api</artifactId>
@@ -1682,7 +1688,13 @@
         <dependency>
           <groupId>org.hamcrest</groupId>
           <artifactId>hamcrest-library</artifactId>
-          <version>1.3</version>
+          <version>${hamcrest.version}</version>
+        </dependency>
+        <dependency>
+          <groupId>org.hamcrest</groupId>
+          <artifactId>hamcrest-core</artifactId>
+          <version>${hamcrest.version}</version>
+          <scope>test</scope>
         </dependency>
         <dependency>
           <groupId>org.assertj</groupId>
@@ -1710,6 +1722,14 @@
         <artifactId>jna</artifactId>
         <version>${jna.version}</version>
       </dependency>
+
+      <dependency>
+        <groupId>net.jodah</groupId>
+        <artifactId>concurrentunit</artifactId>
+        <version>0.4.6</version>
+        <scope>test</scope>
+      </dependency>
+
     </dependencies>
   </dependencyManagement>
 

hadoop-tools/hadoop-azure/pom.xml

@@ -172,6 +172,12 @@
       <groupId>com.google.guava</groupId>
       <artifactId>guava</artifactId>
     </dependency>
+    <dependency>
+      <groupId>com.google.code.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+      <version>3.0.1</version>
+      <scope>provided</scope>
+    </dependency>
 
     <dependency>
       <groupId>org.eclipse.jetty</groupId>
@@ -212,6 +218,11 @@
       <scope>provided</scope>
     </dependency>
 
+    <dependency>
+      <groupId>com.google.code.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
+
     <!-- dependencies use for test only -->
     <dependency>
       <groupId>junit</groupId>
@@ -288,19 +299,14 @@
       <artifactId>hamcrest-library</artifactId>
       <scope>test</scope>
     </dependency>
-
-    <!-- https://.mvnrepository.com/artifact/net.jodah/concurrentunit -->
     <dependency>
-      <groupId>net.jodah</groupId>
-      <artifactId>concurrentunit</artifactId>
-      <version>0.4.6</version>
+      <groupId>org.hamcrest</groupId>
+      <artifactId>hamcrest-core</artifactId>
       <scope>test</scope>
     </dependency>
-    <!-- https://mvnrepository.com/artifact/org.hamcrest/hamcrest-core -->
     <dependency>
-      <groupId>org.hamcrest</groupId>
-      <artifactId>hamcrest-core</artifactId>
-      <version>1.3</version>
+      <groupId>net.jodah</groupId>
+      <artifactId>concurrentunit</artifactId>
       <scope>test</scope>
     </dependency>
 

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsByteBufferPool.java

@@ -18,13 +18,15 @@
 
 package org.apache.hadoop.fs.azurebfs.services;
 
+import java.util.concurrent.ArrayBlockingQueue;
+
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Preconditions;
-
-import java.util.concurrent.ArrayBlockingQueue;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import static java.lang.Math.ceil;
 import static java.lang.Math.min;
+
 import static org.apache.hadoop.fs.azurebfs.constants.FileSystemConfigurations.MAX_VALUE_MAX_AZURE_WRITE_MEM_USAGE_PERCENTAGE;
 import static org.apache.hadoop.fs.azurebfs.constants.FileSystemConfigurations.MIN_VALUE_MAX_AZURE_WRITE_MEM_USAGE_PERCENTAGE;
 
@@ -81,18 +83,18 @@ private void validate(final int queueCapacity,
         .checkArgument(queueCapacity > 0, "queueCapacity cannot be < 1");
   }
 
-  private boolean isPossibleToIssueNewBuffer() {
+  private synchronized boolean isPossibleToIssueNewBuffer() {
     Runtime rt = Runtime.getRuntime();
-    double bufferCountByMaxFreeBuffers = ceil(
-        maxBuffersToPool + rt.availableProcessors());
+    int bufferCountByMaxFreeBuffers =
+        maxBuffersToPool + rt.availableProcessors();
     if (numBuffersInUse >= bufferCountByMaxFreeBuffers) {
       return false;
     }
 
     double freeMemory = rt.maxMemory() - (rt.totalMemory() - rt.freeMemory());
-    double bufferCountByMemory = ceil(
+    int bufferCountByMemory = (int) ceil(
         (freeMemory * maxMemUsagePercentage / HUNDRED) / bufferSize);
-    int maxBuffersThatCanBeInUse = (int) min(bufferCountByMemory,
+    int maxBuffersThatCanBeInUse = min(bufferCountByMemory,
         bufferCountByMaxFreeBuffers);
     if (maxBuffersThatCanBeInUse < 2) {
       maxBuffersThatCanBeInUse = 2;
@@ -133,6 +135,7 @@ public byte[] get() {
   /**
    * @param byteArray The buffer to be offered back to the pool.
    */
+  @SuppressFBWarnings("RV_RETURN_VALUE_IGNORED")
   public synchronized void release(byte[] byteArray) {
     Preconditions.checkArgument(byteArray.length == bufferSize,
         "Buffer size has" + " to be %s (Received buffer length: %s)",