Skip to content

HDDS-1820. Fix numKeys metrics in OM HA. #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2019
Merged

HDDS-1820. Fix numKeys metrics in OM HA. #1116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...zone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,17 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
// return response after releasing lock.
if (exception == null) {
omResponse.setCommitKeyResponse(CommitKeyResponse.newBuilder().build());

// As when we commit the key, then it is visible in ozone, so we should
// increment here.
// As key also can have multiple versions, we need to increment keys
// only if version is 0. Currently we have not complete support of
// versioning of keys. So, this can be revisited later.

if (omKeyInfo.getKeyLocationVersions().size() == 1) {
omMetrics.incNumKeys();
}

return new OMKeyCommitResponse(omKeyInfo, commitKeyRequest.getClientID(),
omResponse.build());
} else {
Expand Down