HADOOP-19218 Avoid DNS lookup while creating IPC Connection object #6916

virajjasani · 2024-07-02T20:34:54Z

Description of PR

Jira: HADOOP-19218

How was this patch tested?

Manual testing + UT

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2024-07-02T22:49:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 9s		trunk passed
-1 ❌	compile	0m 45s	/branch-compile-root-jdkUbuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.txt	root in trunk failed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.
-1 ❌	compile	0m 49s	/branch-compile-root-jdkPrivateBuild-1.8.0_412-8u412-ga-1~20.04.1-b08.txt	root in trunk failed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08.
+1 💚	checkstyle	0m 35s		trunk passed
-1 ❌	mvnsite	0m 12s	/branch-mvnsite-hadoop-common-project_hadoop-common.txt	hadoop-common in trunk failed.
-1 ❌	javadoc	0m 23s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.txt	hadoop-common in trunk failed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.
-1 ❌	javadoc	0m 20s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_412-8u412-ga-1~20.04.1-b08.txt	hadoop-common in trunk failed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08.
+1 💚	spotbugs	1m 22s		trunk passed
+1 💚	shadedclient	23m 46s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 33s		the patch passed
+1 💚	compile	9m 38s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
-1 ❌	javac	9m 38s	/results-compile-javac-root-jdkUbuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.txt	root-jdkUbuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 generated 12 new + 23 unchanged - 0 fixed = 35 total (was 23)
+1 💚	compile	9m 11s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
-1 ❌	javac	9m 11s	/results-compile-javac-root-jdkPrivateBuild-1.8.0_412-8u412-ga-1~20.04.1-b08.txt	root-jdkPrivateBuild-1.8.0_412-8u412-ga-1~~20.04.1-b08 with JDK Private Build-1.8.0_412-8u412-ga-1~~20.04.1-b08 generated 21 new + 23 unchanged - 0 fixed = 44 total (was 23)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 42s	/results-checkstyle-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common: The patch generated 1 new + 239 unchanged - 0 fixed = 240 total (was 239)
+1 💚	mvnsite	1m 3s		the patch passed
+1 💚	javadoc	0m 38s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	0m 36s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	spotbugs	1m 38s		the patch passed
+1 💚	shadedclient	24m 19s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	16m 31s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		132m 58s

Reason	Tests
Failed junit tests	hadoop.net.TestSocketIOWithTimeout
	hadoop.metrics2.source.TestJvmMetrics

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6916/1/artifact/out/Dockerfile
GITHUB PR	#6916
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 34d13a91b041 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5ab974d`
Default Java	Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6916/1/testReport/
Max. process+thread count	1279 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6916/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

shahrs87

+1 The changes looks good to me.

hadoop-yetus · 2024-07-03T01:39:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 44s		trunk passed
+1 💚	compile	9m 50s		trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	compile	9m 17s		trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	checkstyle	0m 52s		trunk passed
+1 💚	mvnsite	1m 0s		trunk passed
+1 💚	javadoc	0m 52s		trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	0m 36s		trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	spotbugs	1m 38s		trunk passed
+1 💚	shadedclient	23m 51s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s		the patch passed
+1 💚	compile	9m 25s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javac	9m 25s		the patch passed
+1 💚	compile	9m 6s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	javac	9m 6s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 44s		the patch passed
+1 💚	mvnsite	0m 56s		the patch passed
+1 💚	javadoc	0m 42s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	0m 36s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	spotbugs	1m 39s		the patch passed
+1 💚	shadedclient	24m 6s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	16m 39s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		149m 58s

Reason	Tests
Failed junit tests	hadoop.metrics2.lib.TestMetricsRegistry
	hadoop.net.TestSocketIOWithTimeout
	hadoop.metrics2.source.TestJvmMetrics

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6916/2/artifact/out/Dockerfile
GITHUB PR	#6916
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 30796cf6ad7a 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `97059ad`
Default Java	Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6916/2/testReport/
Max. process+thread count	1716 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6916/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-07-04T23:25:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	44m 29s		trunk passed
+1 💚	compile	17m 24s		trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	compile	15m 59s		trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	checkstyle	1m 19s		trunk passed
+1 💚	mvnsite	1m 42s		trunk passed
+1 💚	javadoc	1m 17s		trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	0m 54s		trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	spotbugs	2m 35s		trunk passed
+1 💚	shadedclient	35m 31s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 55s		the patch passed
+1 💚	compile	16m 27s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javac	16m 27s		the patch passed
+1 💚	compile	15m 51s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	javac	15m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 15s		the patch passed
+1 💚	mvnsite	1m 38s		the patch passed
+1 💚	javadoc	1m 12s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	0m 55s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	spotbugs	2m 44s		the patch passed
+1 💚	shadedclient	36m 14s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 30s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 3s		The patch does not generate ASF License warnings.
		220m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6916/3/artifact/out/Dockerfile
GITHUB PR	#6916
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 2971f14025b3 5.15.0-113-generic #123-Ubuntu SMP Mon Jun 10 08:16:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `97059ad`
Default Java	Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6916/3/testReport/
Max. process+thread count	1429 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6916/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hexiaoqiao

LGTM. +1.

Hexiaoqiao · 2024-07-16T13:09:43Z

Committed to trunk. Thanks @virajjasani for your works and @shahrs87 @zeekling @d-c-manning for your reviews!

…6916). Contributed by Viraj Jasani. Signed-off-by: Rushabh Shah <[email protected]> Signed-off-by: He Xiaoqiao <[email protected]> (cherry picked from commit 1360c75)

…pache#6916). Contributed by Viraj Jasani. Signed-off-by: Rushabh Shah <[email protected]> Signed-off-by: He Xiaoqiao <[email protected]>

HADOOP-19218 Avoid DNS lookup while creating IPC Connection object

5ab974d

github-actions bot added trunk Common labels Jul 2, 2024

checkstyle

97059ad

shahrs87 approved these changes Jul 3, 2024

View reviewed changes

zeekling approved these changes Jul 7, 2024

View reviewed changes

d-c-manning approved these changes Jul 14, 2024

View reviewed changes

Hexiaoqiao approved these changes Jul 16, 2024

View reviewed changes

Hexiaoqiao merged commit 1360c75 into apache:trunk Jul 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-19218 Avoid DNS lookup while creating IPC Connection object #6916

HADOOP-19218 Avoid DNS lookup while creating IPC Connection object #6916

Uh oh!

virajjasani commented Jul 2, 2024

Uh oh!

hadoop-yetus commented Jul 2, 2024

Uh oh!

shahrs87 left a comment

Uh oh!

hadoop-yetus commented Jul 3, 2024

Uh oh!

hadoop-yetus commented Jul 4, 2024

Uh oh!

Hexiaoqiao left a comment

Uh oh!

Hexiaoqiao commented Jul 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

HADOOP-19218 Avoid DNS lookup while creating IPC Connection object #6916

HADOOP-19218 Avoid DNS lookup while creating IPC Connection object #6916

Uh oh!

Conversation

virajjasani commented Jul 2, 2024

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Jul 2, 2024

Uh oh!

shahrs87 left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jul 3, 2024

Uh oh!

hadoop-yetus commented Jul 4, 2024

Uh oh!

Hexiaoqiao left a comment

Choose a reason for hiding this comment

Uh oh!

Hexiaoqiao commented Jul 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants