Skip to content

Commit 0838c35

Browse files
murtazahassan123saintstack
authored andcommitted
HBASE-2284 Javadoc Warnings: Fix warnings coming due to @Result tag in TestCoprocessorWhitelistMasterObserver (#256)
1 parent aab70b5 commit 0838c35

File tree

1 file changed

+28
-35
lines changed

1 file changed

+28
-35
lines changed

hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCoprocessorWhitelistMasterObserver.java

Lines changed: 28 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ public void tearDownTestCoprocessorWhitelistMasterObserver() throws Exception {
8686

8787
/**
8888
* Test a table modification adding a coprocessor path
89-
* which is not whitelisted
90-
* @result An IOException should be thrown and caught
89+
* which is not whitelisted.
90+
* @exception Exception should be thrown and caught
9191
* to show coprocessor is working as desired
9292
* @param whitelistedPaths A String array of paths to add in
9393
* for the whitelisting configuration
@@ -127,9 +127,8 @@ private static void positiveTestCase(String[] whitelistedPaths,
127127

128128
/**
129129
* Test a table modification adding a coprocessor path
130-
* which is whitelisted
131-
* @result The coprocessor should be added to the table
132-
* descriptor successfully
130+
* which is whitelisted. The coprocessor should be added to
131+
* the table descriptor successfully.
133132
* @param whitelistedPaths A String array of paths to add in
134133
* for the whitelisting configuration
135134
* @param coprocessorPath A String to use as the
@@ -168,8 +167,8 @@ private static void negativeTestCase(String[] whitelistedPaths,
168167

169168
/**
170169
* Test a table modification adding a coprocessor path
171-
* which is not whitelisted
172-
* @result An IOException should be thrown and caught
170+
* which is not whitelisted.
171+
* @exception Exception should be thrown and caught
173172
* to show coprocessor is working as desired
174173
*/
175174
@Test
@@ -180,10 +179,9 @@ public void testSubstringNonWhitelisted() throws Exception {
180179

181180
/**
182181
* Test a table creation including a coprocessor path
183-
* which is not whitelisted
184-
* @result Coprocessor should be added to table descriptor
185-
* Table is disabled to avoid an IOException due to
186-
* the added coprocessor not actually existing on disk
182+
* which is not whitelisted. Coprocessor should be added to
183+
* table descriptor. Table is disabled to avoid an IOException due
184+
* to the added coprocessor not actually existing on disk.
187185
*/
188186
@Test
189187
public void testDifferentFileSystemNonWhitelisted() throws Exception {
@@ -193,10 +191,9 @@ public void testDifferentFileSystemNonWhitelisted() throws Exception {
193191

194192
/**
195193
* Test a table modification adding a coprocessor path
196-
* which is whitelisted
197-
* @result Coprocessor should be added to table descriptor
198-
* Table is disabled to avoid an IOException due to
199-
* the added coprocessor not actually existing on disk
194+
* which is whitelisted. Coprocessor should be added to table
195+
* descriptor. Table is disabled to avoid an IOException due to
196+
* the added coprocessor not actually existing on disk.
200197
*/
201198
@Test
202199
public void testSchemeAndDirectorywhitelisted() throws Exception {
@@ -206,10 +203,9 @@ public void testSchemeAndDirectorywhitelisted() throws Exception {
206203

207204
/**
208205
* Test a table modification adding a coprocessor path
209-
* which is whitelisted
210-
* @result Coprocessor should be added to table descriptor
211-
* Table is disabled to avoid an IOException due to
212-
* the added coprocessor not actually existing on disk
206+
* which is whitelisted. Coprocessor should be added to table
207+
* descriptor. Table is disabled to avoid an IOException due to
208+
* the added coprocessor not actually existing on disk.
213209
*/
214210
@Test
215211
public void testSchemeWhitelisted() throws Exception {
@@ -219,10 +215,9 @@ public void testSchemeWhitelisted() throws Exception {
219215

220216
/**
221217
* Test a table modification adding a coprocessor path
222-
* which is whitelisted
223-
* @result Coprocessor should be added to table descriptor
224-
* Table is disabled to avoid an IOException due to
225-
* the added coprocessor not actually existing on disk
218+
* which is whitelisted. Coprocessor should be added to table
219+
* descriptor. Table is disabled to avoid an IOException due to
220+
* the added coprocessor not actually existing on disk.
226221
*/
227222
@Test
228223
public void testDFSNameWhitelistedWorks() throws Exception {
@@ -232,10 +227,9 @@ public void testDFSNameWhitelistedWorks() throws Exception {
232227

233228
/**
234229
* Test a table modification adding a coprocessor path
235-
* which is whitelisted
236-
* @result Coprocessor should be added to table descriptor
237-
* Table is disabled to avoid an IOException due to
238-
* the added coprocessor not actually existing on disk
230+
* which is whitelisted. Coprocessor should be added to table
231+
* descriptor. Table is disabled to avoid an IOException due to
232+
* the added coprocessor not actually existing on disk.
239233
*/
240234
@Test
241235
public void testDFSNameNotWhitelistedFails() throws Exception {
@@ -245,10 +239,9 @@ public void testDFSNameNotWhitelistedFails() throws Exception {
245239

246240
/**
247241
* Test a table modification adding a coprocessor path
248-
* which is whitelisted
249-
* @result Coprocessor should be added to table descriptor
250-
* Table is disabled to avoid an IOException due to
251-
* the added coprocessor not actually existing on disk
242+
* which is whitelisted. Coprocessor should be added to table
243+
* descriptor. Table is disabled to avoid an IOException due to
244+
* the added coprocessor not actually existing on disk.
252245
*/
253246
@Test
254247
public void testBlanketWhitelist() throws Exception {
@@ -258,8 +251,8 @@ public void testBlanketWhitelist() throws Exception {
258251

259252
/**
260253
* Test a table creation including a coprocessor path
261-
* which is not whitelisted
262-
* @result Table will not be created due to the offending coprocessor
254+
* which is not whitelisted. Table will not be created due to the
255+
* offending coprocessor.
263256
*/
264257
@Test
265258
public void testCreationNonWhitelistedCoprocessorPath() throws Exception {
@@ -303,8 +296,8 @@ public Optional<RegionObserver> getRegionObserver() {
303296

304297
/**
305298
* Test a table creation including a coprocessor path
306-
* which is on the classpath
307-
* @result Table will be created with the coprocessor
299+
* which is on the classpath. Table will be created with the
300+
* coprocessor.
308301
*/
309302
@Test
310303
public void testCreationClasspathCoprocessor() throws Exception {

0 commit comments

Comments
 (0)