Skip to content

Commit 2747320

Browse files
committed
HBASE-28389 HBase backup yarn queue parameter ignored (#6130)
Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: DieterDP <[email protected]> (cherry picked from commit 68045db)
1 parent 839a5f4 commit 2747320

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreDriver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ private int parseAndRun() throws IOException {
124124

125125
if (cmd.hasOption(OPTION_YARN_QUEUE_NAME)) {
126126
String queueName = cmd.getOptionValue(OPTION_YARN_QUEUE_NAME);
127-
// Set system property value for MR job
128-
System.setProperty("mapreduce.job.queuename", queueName);
127+
// Set MR job queuename to configuration
128+
getConf().set("mapreduce.job.queuename", queueName);
129129
}
130130

131131
// parse main restore command options

hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,12 @@ public void execute() throws IOException {
142142
throw new IOException(INCORRECT_USAGE);
143143
}
144144

145+
if (cmdline.hasOption(OPTION_YARN_QUEUE_NAME)) {
146+
String queueName = cmdline.getOptionValue(OPTION_YARN_QUEUE_NAME);
147+
// Set MR job queuename to configuration
148+
getConf().set("mapreduce.job.queuename", queueName);
149+
}
150+
145151
// Create connection
146152
conn = ConnectionFactory.createConnection(getConf());
147153
if (requiresNoActiveSession()) {
@@ -333,12 +339,6 @@ public void execute() throws IOException {
333339

334340
boolean ignoreChecksum = cmdline.hasOption(OPTION_IGNORECHECKSUM);
335341

336-
if (cmdline.hasOption(OPTION_YARN_QUEUE_NAME)) {
337-
String queueName = cmdline.getOptionValue(OPTION_YARN_QUEUE_NAME);
338-
// Set system property value for MR job
339-
System.setProperty("mapreduce.job.queuename", queueName);
340-
}
341-
342342
try (BackupAdminImpl admin = new BackupAdminImpl(conn)) {
343343
BackupRequest.Builder builder = new BackupRequest.Builder();
344344
BackupRequest request = builder.withBackupType(BackupType.valueOf(args[1].toUpperCase()))

0 commit comments

Comments
 (0)