Skip to content

Commit 37d62aa

Browse files
committed
HBASE-27951 Use ADMIN_QOS in MasterRpcServices for regionserver operational dependencies (#5309)
It seems not correct to have the MasterRpcServices methods for direct regionserver<->master communication (regionServerStartup, regionServerReport, and reportFatalRSError) contending with normal priority requests. They should be made ADMIN_QOS priority to avoid potential operational deadlocks. Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]>
1 parent c0df943 commit 37d62aa

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,7 @@ public GetLastFlushedSequenceIdResponse getLastFlushedSequenceId(RpcController c
539539
}
540540

541541
@Override
542+
@QosPriority(priority = HConstants.ADMIN_QOS)
542543
public RegionServerReportResponse regionServerReport(RpcController controller,
543544
RegionServerReportRequest request) throws ServiceException {
544545
try {
@@ -570,6 +571,7 @@ public RegionServerReportResponse regionServerReport(RpcController controller,
570571
}
571572

572573
@Override
574+
@QosPriority(priority = HConstants.ADMIN_QOS)
573575
public RegionServerStartupResponse regionServerStartup(RpcController controller,
574576
RegionServerStartupRequest request) throws ServiceException {
575577
// Register with server manager
@@ -601,6 +603,7 @@ public RegionServerStartupResponse regionServerStartup(RpcController controller,
601603
}
602604

603605
@Override
606+
@QosPriority(priority = HConstants.ADMIN_QOS)
604607
public ReportRSFatalErrorResponse reportRSFatalError(RpcController controller,
605608
ReportRSFatalErrorRequest request) throws ServiceException {
606609
String errorText = request.getErrorMessage();

0 commit comments

Comments
 (0)