Skip to content

Commit 9e8e438

Browse files
authored
HBASE-27951 Use ADMIN_QOS in MasterRpcServices for regionserver operational dependencies (#5309)
It seems not correct to have the MasterRpcServices methods for direct regionserver<->master communication (regionServerStartup, regionServerReport, and reportFatalRSError) contending with normal priority requests. They should be made ADMIN_QOS priority to avoid potential operational deadlocks. Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]>
1 parent 0637bbc commit 9e8e438

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -618,6 +618,7 @@ public GetLastFlushedSequenceIdResponse getLastFlushedSequenceId(RpcController c
618618
}
619619

620620
@Override
621+
@QosPriority(priority = HConstants.ADMIN_QOS)
621622
public RegionServerReportResponse regionServerReport(RpcController controller,
622623
RegionServerReportRequest request) throws ServiceException {
623624
try {
@@ -653,6 +654,7 @@ public RegionServerReportResponse regionServerReport(RpcController controller,
653654
}
654655

655656
@Override
657+
@QosPriority(priority = HConstants.ADMIN_QOS)
656658
public RegionServerStartupResponse regionServerStartup(RpcController controller,
657659
RegionServerStartupRequest request) throws ServiceException {
658660
// Register with server manager
@@ -684,6 +686,7 @@ public RegionServerStartupResponse regionServerStartup(RpcController controller,
684686
}
685687

686688
@Override
689+
@QosPriority(priority = HConstants.ADMIN_QOS)
687690
public ReportRSFatalErrorResponse reportRSFatalError(RpcController controller,
688691
ReportRSFatalErrorRequest request) throws ServiceException {
689692
String errorText = request.getErrorMessage();

0 commit comments

Comments
 (0)