From 08b57d78c48ec6d86d8140fc136978751ebefc7b Mon Sep 17 00:00:00 2001 From: Duo Zhang Date: Fri, 31 Dec 2021 12:10:08 +0800 Subject: [PATCH 1/4] HBASE-26523 Upgrade hbase-thirdparty dependency to 4.0.1 (#3988) Signed-off-by: GeorryHuang --- .../hbase/http/resource/JerseyResource.java | 16 +++++----- .../apache/hadoop/hbase/MockHttpApiRule.java | 2 +- .../hadoop/hbase/RESTApiClusterManager.java | 16 +++++----- hbase-rest/pom.xml | 8 ++--- .../hadoop/hbase/rest/ExistsResource.java | 15 +++++---- .../hadoop/hbase/rest/MultiRowResource.java | 13 ++++---- .../rest/NamespacesInstanceResource.java | 25 ++++++++------- .../hadoop/hbase/rest/NamespacesResource.java | 15 +++++---- .../hbase/rest/ProtobufStreamingOutput.java | 5 +-- .../apache/hadoop/hbase/rest/RESTServer.java | 2 +- .../hadoop/hbase/rest/RegionsResource.java | 15 +++++---- .../hadoop/hbase/rest/ResourceBase.java | 5 +-- .../hadoop/hbase/rest/RootResource.java | 19 +++++------ .../apache/hadoop/hbase/rest/RowResource.java | 25 ++++++++------- .../hbase/rest/ScannerInstanceResource.java | 19 +++++------ .../hadoop/hbase/rest/ScannerResource.java | 19 +++++------ .../hadoop/hbase/rest/SchemaResource.java | 25 ++++++++------- .../rest/StorageClusterStatusResource.java | 15 +++++---- .../rest/StorageClusterVersionResource.java | 15 +++++---- .../hadoop/hbase/rest/TableResource.java | 11 ++++--- .../hadoop/hbase/rest/TableScanResource.java | 17 +++++----- .../hadoop/hbase/rest/VersionResource.java | 17 +++++----- .../hadoop/hbase/rest/model/ScannerModel.java | 5 +-- .../rest/provider/JAXBContextResolver.java | 5 +-- .../consumer/ProtobufMessageBodyConsumer.java | 13 ++++---- .../PlainTextMessageBodyProducer.java | 13 ++++---- .../producer/ProtobufMessageBodyProducer.java | 13 ++++---- .../hadoop/hbase/rest/RowResourceBase.java | 5 +-- .../hbase/rest/TestMultiRowResource.java | 7 ++-- .../rest/TestNamespacesInstanceResource.java | 7 ++-- .../hbase/rest/TestSecureRESTServer.java | 5 +-- .../hadoop/hbase/rest/TestTableScan.java | 7 ++-- .../hbase/rest/TestVersionResource.java | 7 ++-- .../hbase/rest/model/TestModelBase.java | 5 +-- .../hbase/coprocessor/MetaTableMetrics.java | 32 ++++++++----------- .../hbase/io/hfile/LruCachedBlockQueue.java | 11 ++++++- .../io/hfile/bucket/CachedEntryQueue.java | 7 ++++ pom.xml | 28 ++++++++++++---- 38 files changed, 273 insertions(+), 216 deletions(-) diff --git a/hbase-http/src/test/java/org/apache/hadoop/hbase/http/resource/JerseyResource.java b/hbase-http/src/test/java/org/apache/hadoop/hbase/http/resource/JerseyResource.java index aaba50fa187d..89d71b403af7 100644 --- a/hbase-http/src/test/java/org/apache/hadoop/hbase/http/resource/JerseyResource.java +++ b/hbase-http/src/test/java/org/apache/hadoop/hbase/http/resource/JerseyResource.java @@ -20,17 +20,17 @@ import java.io.IOException; import java.util.Map; import java.util.TreeMap; -import javax.ws.rs.DefaultValue; -import javax.ws.rs.GET; -import javax.ws.rs.Path; -import javax.ws.rs.PathParam; -import javax.ws.rs.Produces; -import javax.ws.rs.QueryParam; -import javax.ws.rs.core.MediaType; -import javax.ws.rs.core.Response; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.apache.hbase.thirdparty.javax.ws.rs.DefaultValue; +import org.apache.hbase.thirdparty.javax.ws.rs.GET; +import org.apache.hbase.thirdparty.javax.ws.rs.Path; +import org.apache.hbase.thirdparty.javax.ws.rs.PathParam; +import org.apache.hbase.thirdparty.javax.ws.rs.Produces; +import org.apache.hbase.thirdparty.javax.ws.rs.QueryParam; +import org.apache.hbase.thirdparty.javax.ws.rs.core.MediaType; +import org.apache.hbase.thirdparty.javax.ws.rs.core.Response; import org.apache.hbase.thirdparty.org.eclipse.jetty.util.ajax.JSON; /** diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/MockHttpApiRule.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/MockHttpApiRule.java index 2e48a7c9a6a7..5817d071f02c 100644 --- a/hbase-it/src/test/java/org/apache/hadoop/hbase/MockHttpApiRule.java +++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/MockHttpApiRule.java @@ -28,11 +28,11 @@ import java.util.regex.Pattern; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; -import javax.ws.rs.core.MediaType; import org.junit.rules.ExternalResource; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.apache.hbase.thirdparty.javax.ws.rs.core.MediaType; import org.apache.hbase.thirdparty.org.eclipse.jetty.server.Request; import org.apache.hbase.thirdparty.org.eclipse.jetty.server.RequestLog; import org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server; diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java index cd410d332f34..8c5339605e29 100644 --- a/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java +++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java @@ -31,14 +31,6 @@ import java.util.Objects; import java.util.Optional; import java.util.concurrent.Callable; -import javax.ws.rs.client.Client; -import javax.ws.rs.client.ClientBuilder; -import javax.ws.rs.client.Entity; -import javax.ws.rs.client.Invocation; -import javax.ws.rs.client.WebTarget; -import javax.ws.rs.core.MediaType; -import javax.ws.rs.core.Response; -import javax.ws.rs.core.UriBuilder; import javax.xml.ws.http.HTTPException; import org.apache.commons.lang3.StringUtils; import org.apache.hadoop.conf.Configuration; @@ -53,6 +45,14 @@ import org.apache.hbase.thirdparty.com.google.gson.JsonElement; import org.apache.hbase.thirdparty.com.google.gson.JsonObject; import org.apache.hbase.thirdparty.com.google.gson.JsonParser; +import org.apache.hbase.thirdparty.javax.ws.rs.client.Client; +import org.apache.hbase.thirdparty.javax.ws.rs.client.ClientBuilder; +import org.apache.hbase.thirdparty.javax.ws.rs.client.Entity; +import org.apache.hbase.thirdparty.javax.ws.rs.client.Invocation; +import org.apache.hbase.thirdparty.javax.ws.rs.client.WebTarget; +import org.apache.hbase.thirdparty.javax.ws.rs.core.MediaType; +import org.apache.hbase.thirdparty.javax.ws.rs.core.Response; +import org.apache.hbase.thirdparty.javax.ws.rs.core.UriBuilder; import org.apache.hbase.thirdparty.org.glassfish.jersey.client.authentication.HttpAuthenticationFeature; /** diff --git a/hbase-rest/pom.xml b/hbase-rest/pom.xml index de7159794f18..808639c99c81 100644 --- a/hbase-rest/pom.xml +++ b/hbase-rest/pom.xml @@ -165,10 +165,6 @@ com.sun.activation javax.activation - - com.fasterxml.jackson.jaxrs - jackson-jaxrs-json-provider - com.fasterxml.jackson.core jackson-annotations @@ -181,6 +177,10 @@ com.fasterxml.jackson.core jackson-databind + + org.apache.hbase.thirdparty + hbase-shaded-jackson-jaxrs-json-provider + @@ -1165,11 +1165,6 @@ joni ${joni.version} - - com.fasterxml.jackson.jaxrs - jackson-jaxrs-json-provider - ${jackson.version} - com.fasterxml.jackson.core jackson-annotations @@ -1389,6 +1384,11 @@ hbase-shaded-jersey ${hbase-thirdparty.version} + + org.apache.hbase.thirdparty + hbase-shaded-jackson-jaxrs-json-provider + ${hbase-thirdparty.version} + com.sun.xml.ws jaxws-ri @@ -2070,6 +2070,22 @@ org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting + + true + 512 + Use shaded javax.ws.rs in hbase-thirdparty + + javax.ws.rs.** + + + + true + 512 + Use shaded jackson-jaxrs-json-provider in hbase-thirdparty + + com.fasterxml.jackson.jaxrs.** + + From b1c10be5e1d805ebd5fdf87bfe72e7b42cbaeeb2 Mon Sep 17 00:00:00 2001 From: Duo Zhang Date: Sat, 12 Mar 2022 16:51:49 +0800 Subject: [PATCH 2/4] HBASE-25465 Use javac --release option for supporting cross version compilation (#4164) Signed-off-by: Andrew Purtell --- .../hadoop/hbase/filter/FuzzyRowFilter.java | 5 +- hbase-common/pom.xml | 4 + .../hadoop/hbase/io/ByteBuffAllocator.java | 9 +- .../hadoop/hbase/nio/SingleByteBuff.java | 9 +- .../hadoop/hbase/util/ByteBufferUtils.java | 35 ++- .../org/apache/hadoop/hbase/util/Bytes.java | 37 ++-- .../apache/hadoop/hbase/util/ClassSize.java | 22 +- .../hadoop/hbase/util/UnsafeAccess.java | 206 ++++++++++-------- .../hadoop/hbase/util/UnsafeAvailChecker.java | 189 ---------------- .../hbase/util/TestByteBufferUtils.java | 13 +- .../apache/hadoop/hbase/util/TestBytes.java | 3 +- .../hadoop/hbase/rest/TestRESTServerSSL.java | 25 ++- .../hbase/regionserver/HRegionServer.java | 4 +- pom.xml | 13 +- 14 files changed, 214 insertions(+), 360 deletions(-) delete mode 100644 hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java index 7beeae0334ff..5f3e2b3da736 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java @@ -27,9 +27,9 @@ import org.apache.hadoop.hbase.CellComparator; import org.apache.hadoop.hbase.PrivateCellUtil; import org.apache.hadoop.hbase.exceptions.DeserializationException; +import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; import org.apache.hadoop.hbase.util.Bytes; import org.apache.hadoop.hbase.util.Pair; -import org.apache.hadoop.hbase.util.UnsafeAvailChecker; import org.apache.yetus.audience.InterfaceAudience; import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException; @@ -58,7 +58,8 @@ */ @InterfaceAudience.Public public class FuzzyRowFilter extends FilterBase { - private static final boolean UNSAFE_UNALIGNED = UnsafeAvailChecker.unaligned(); + + private static final boolean UNSAFE_UNALIGNED = HBasePlatformDependent.unaligned(); // the wildcard byte is 1 on the user side. but the filter converts it internally // in preprocessMask. This was changed in HBASE-15676 due to a bug with using 0. diff --git a/hbase-common/pom.xml b/hbase-common/pom.xml index 2ce213131b8f..0ed868628e38 100644 --- a/hbase-common/pom.xml +++ b/hbase-common/pom.xml @@ -60,6 +60,10 @@ org.apache.hbase.thirdparty hbase-shaded-netty + + org.apache.hbase.thirdparty + hbase-unsafe + org.slf4j slf4j-api diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java index 1ef206438558..711153b77627 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java @@ -29,10 +29,10 @@ import org.apache.hadoop.hbase.nio.ByteBuff; import org.apache.hadoop.hbase.nio.SingleByteBuff; import org.apache.hadoop.hbase.util.ReflectionUtils; +import org.apache.hadoop.hbase.util.UnsafeAccess; import org.apache.yetus.audience.InterfaceAudience; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import sun.nio.ch.DirectBuffer; import org.apache.hbase.thirdparty.com.google.common.collect.Sets; @@ -362,11 +362,8 @@ public ByteBuff allocate(int size) { public void clean() { while (!buffers.isEmpty()) { ByteBuffer b = buffers.poll(); - if (b instanceof DirectBuffer) { - DirectBuffer db = (DirectBuffer) b; - if (db.cleaner() != null) { - db.cleaner().clean(); - } + if (b.isDirect()) { + UnsafeAccess.freeDirectBuffer(b); } } this.usedBufCount.set(0); diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/nio/SingleByteBuff.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/nio/SingleByteBuff.java index 5945e4c3c819..320696ada703 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/nio/SingleByteBuff.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/nio/SingleByteBuff.java @@ -24,12 +24,11 @@ import java.nio.channels.FileChannel; import java.nio.channels.ReadableByteChannel; import org.apache.hadoop.hbase.io.ByteBuffAllocator.Recycler; +import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; import org.apache.hadoop.hbase.util.ByteBufferUtils; import org.apache.hadoop.hbase.util.ObjectIntPair; import org.apache.hadoop.hbase.util.UnsafeAccess; -import org.apache.hadoop.hbase.util.UnsafeAvailChecker; import org.apache.yetus.audience.InterfaceAudience; -import sun.nio.ch.DirectBuffer; /** * An implementation of ByteBuff where a single BB backs the BBI. This just acts as a wrapper over a @@ -38,8 +37,8 @@ @InterfaceAudience.Private public class SingleByteBuff extends ByteBuff { - private static final boolean UNSAFE_AVAIL = UnsafeAvailChecker.isAvailable(); - private static final boolean UNSAFE_UNALIGNED = UnsafeAvailChecker.unaligned(); + private static final boolean UNSAFE_AVAIL = HBasePlatformDependent.isUnsafeAvailable(); + private static final boolean UNSAFE_UNALIGNED = HBasePlatformDependent.unaligned(); // Underlying BB private final ByteBuffer buf; @@ -63,7 +62,7 @@ public SingleByteBuff(Recycler recycler, ByteBuffer buf) { this.unsafeOffset = UnsafeAccess.BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset(); this.unsafeRef = buf.array(); } else { - this.unsafeOffset = ((DirectBuffer) buf).address(); + this.unsafeOffset = UnsafeAccess.directBufferAddress(buf); } } diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java index 95716d661a61..82f699ab7b52 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java @@ -31,17 +31,16 @@ import org.apache.hadoop.hbase.io.ByteBufferWriter; import org.apache.hadoop.hbase.io.util.StreamUtils; import org.apache.hadoop.hbase.nio.ByteBuff; +import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; import org.apache.hadoop.io.IOUtils; import org.apache.hadoop.io.WritableUtils; import org.apache.yetus.audience.InterfaceAudience; -import sun.nio.ch.DirectBuffer; /** * Utility functions for working with byte buffers, such as reading/writing variable-length long * numbers. * @deprecated This class will become IA.Private in HBase 3.0. Downstream folks shouldn't use it. */ -@SuppressWarnings("restriction") @Deprecated @InterfaceAudience.Public public final class ByteBufferUtils { @@ -50,8 +49,8 @@ public final class ByteBufferUtils { public final static int NEXT_BIT_SHIFT = 7; public final static int NEXT_BIT_MASK = 1 << 7; @InterfaceAudience.Private - final static boolean UNSAFE_AVAIL = UnsafeAvailChecker.isAvailable(); - public final static boolean UNSAFE_UNALIGNED = UnsafeAvailChecker.unaligned(); + final static boolean UNSAFE_AVAIL = HBasePlatformDependent.isUnsafeAvailable(); + public final static boolean UNSAFE_UNALIGNED = HBasePlatformDependent.unaligned(); private ByteBufferUtils() { } @@ -91,11 +90,10 @@ static class ComparerHolder { static Comparer getBestComparer() { try { - Class theClass = Class.forName(UNSAFE_COMPARER_NAME); + Class theClass = + Class.forName(UNSAFE_COMPARER_NAME).asSubclass(Comparer.class); - @SuppressWarnings("unchecked") - Comparer comparer = (Comparer) theClass.getConstructor().newInstance(); - return comparer; + return theClass.getConstructor().newInstance(); } catch (Throwable t) { // ensure we really catch *everything* return PureJavaComparer.INSTANCE; } @@ -152,7 +150,7 @@ public int compareTo(byte[] buf1, int o1, int l1, ByteBuffer buf2, int o2, int l long offset2Adj; Object refObj2 = null; if (buf2.isDirect()) { - offset2Adj = o2 + ((DirectBuffer) buf2).address(); + offset2Adj = o2 + UnsafeAccess.directBufferAddress(buf2); } else { offset2Adj = o2 + buf2.arrayOffset() + UnsafeAccess.BYTE_ARRAY_BASE_OFFSET; refObj2 = buf2.array(); @@ -166,13 +164,13 @@ public int compareTo(ByteBuffer buf1, int o1, int l1, ByteBuffer buf2, int o2, i long offset1Adj, offset2Adj; Object refObj1 = null, refObj2 = null; if (buf1.isDirect()) { - offset1Adj = o1 + ((DirectBuffer) buf1).address(); + offset1Adj = o1 + UnsafeAccess.directBufferAddress(buf1); } else { offset1Adj = o1 + buf1.arrayOffset() + UnsafeAccess.BYTE_ARRAY_BASE_OFFSET; refObj1 = buf1.array(); } if (buf2.isDirect()) { - offset2Adj = o2 + ((DirectBuffer) buf2).address(); + offset2Adj = o2 + UnsafeAccess.directBufferAddress(buf2); } else { offset2Adj = o2 + buf2.arrayOffset() + UnsafeAccess.BYTE_ARRAY_BASE_OFFSET; refObj2 = buf2.array(); @@ -189,12 +187,11 @@ static class ConverterHolder { static Converter getBestConverter() { try { - Class theClass = Class.forName(UNSAFE_CONVERTER_NAME); + Class theClass = + Class.forName(UNSAFE_CONVERTER_NAME).asSubclass(Converter.class); // yes, UnsafeComparer does implement Comparer - @SuppressWarnings("unchecked") - Converter converter = (Converter) theClass.getConstructor().newInstance(); - return converter; + return theClass.getConstructor().newInstance(); } catch (Throwable t) { // ensure we really catch *everything* return PureJavaConverter.INSTANCE; } @@ -932,8 +929,8 @@ static int compareToUnsafe(Object obj1, long o1, int l1, Object obj2, long o2, i * 64-bit. */ for (i = 0; i < strideLimit; i += stride) { - long lw = UnsafeAccess.theUnsafe.getLong(obj1, o1 + (long) i); - long rw = UnsafeAccess.theUnsafe.getLong(obj2, o2 + (long) i); + long lw = HBasePlatformDependent.getLong(obj1, o1 + (long) i); + long rw = HBasePlatformDependent.getLong(obj2, o2 + (long) i); if (lw != rw) { if (!UnsafeAccess.LITTLE_ENDIAN) { return ((lw + Long.MIN_VALUE) < (rw + Long.MIN_VALUE)) ? -1 : 1; @@ -953,8 +950,8 @@ static int compareToUnsafe(Object obj1, long o1, int l1, Object obj2, long o2, i // The epilogue to cover the last (minLength % stride) elements. for (; i < minLength; i++) { - int il = (UnsafeAccess.theUnsafe.getByte(obj1, o1 + i) & 0xFF); - int ir = (UnsafeAccess.theUnsafe.getByte(obj2, o2 + i) & 0xFF); + int il = (HBasePlatformDependent.getByte(obj1, o1 + i) & 0xFF); + int ir = (HBasePlatformDependent.getByte(obj2, o2 + i) & 0xFF); if (il != ir) { return il - ir; } diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java index ef35f729d325..75b57867276e 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java @@ -42,13 +42,13 @@ import org.apache.hadoop.hbase.Cell; import org.apache.hadoop.hbase.CellComparator; import org.apache.hadoop.hbase.KeyValue; +import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; import org.apache.hadoop.io.RawComparator; import org.apache.hadoop.io.WritableComparator; import org.apache.hadoop.io.WritableUtils; import org.apache.yetus.audience.InterfaceAudience; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import sun.misc.Unsafe; import org.apache.hbase.thirdparty.org.apache.commons.collections4.CollectionUtils; @@ -56,7 +56,6 @@ * Utility class that handles byte arrays, conversions to/from other types, comparisons, hash code * generation, manufacturing keys for HashMaps or HashSets, and can be used as key in maps or trees. */ -@SuppressWarnings("restriction") @InterfaceAudience.Public @edu.umd.cs.findbugs.annotations.SuppressWarnings( value = "EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS", @@ -127,7 +126,7 @@ public class Bytes implements Comparable { public static final int ESTIMATED_HEAP_TAX = 16; @InterfaceAudience.Private - static final boolean UNSAFE_UNALIGNED = UnsafeAvailChecker.unaligned(); + static final boolean UNSAFE_UNALIGNED = HBasePlatformDependent.unaligned(); /** * Returns length of the byte array, returning 0 if the array is null. Useful for calculating @@ -1428,22 +1427,17 @@ int putShort(byte[] bytes, int offset, short val) { protected static final class UnsafeConverter extends Converter { - static final Unsafe theUnsafe; - - public UnsafeConverter() { - } + public UnsafeConverter() {} static { - if (UNSAFE_UNALIGNED) { - theUnsafe = UnsafeAccess.theUnsafe; - } else { + if (!UNSAFE_UNALIGNED) { // It doesn't matter what we throw; // it's swallowed in getBestComparer(). throw new Error(); } // sanity check - this should never fail - if (theUnsafe.arrayIndexScale(byte[].class) != 1) { + if (HBasePlatformDependent.arrayIndexScale(byte[].class) != 1) { throw new AssertionError(); } } @@ -1481,11 +1475,11 @@ int putShort(byte[] bytes, int offset, short val) { } /** - * Provides a lexicographical comparer implementation; either a Java implementation or a faster - * implementation based on {@link Unsafe}. - *

- * Uses reflection to gracefully fall back to the Java implementation if {@code Unsafe} isn't - * available. + * Provides a lexicographical comparer implementation; either a Java + * implementation or a faster implementation based on {@code Unsafe}. + * + *

Uses reflection to gracefully fall back to the Java implementation if + * {@code Unsafe} isn't available. */ @InterfaceAudience.Private static class LexicographicalComparerHolder { @@ -1539,18 +1533,15 @@ public int compareTo(byte[] buffer1, int offset1, int length1, byte[] buffer2, i enum UnsafeComparer implements Comparer { INSTANCE; - static final Unsafe theUnsafe; static { - if (UNSAFE_UNALIGNED) { - theUnsafe = UnsafeAccess.theUnsafe; - } else { + if (!UNSAFE_UNALIGNED) { // It doesn't matter what we throw; // it's swallowed in getBestComparer(). throw new Error(); } // sanity check - this should never fail - if (theUnsafe.arrayIndexScale(byte[].class) != 1) { + if (HBasePlatformDependent.arrayIndexScale(byte[].class) != 1) { throw new AssertionError(); } } @@ -1585,8 +1576,8 @@ public int compareTo(byte[] buffer1, int offset1, int length1, byte[] buffer2, i * than 4 bytes even on 32-bit. On the other hand, it is substantially faster on 64-bit. */ for (i = 0; i < strideLimit; i += stride) { - long lw = theUnsafe.getLong(buffer1, offset1Adj + i); - long rw = theUnsafe.getLong(buffer2, offset2Adj + i); + long lw = HBasePlatformDependent.getLong(buffer1, offset1Adj + i); + long rw = HBasePlatformDependent.getLong(buffer2, offset2Adj + i); if (lw != rw) { if (!UnsafeAccess.LITTLE_ENDIAN) { return ((lw + Long.MIN_VALUE) < (rw + Long.MIN_VALUE)) ? -1 : 1; diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java index 7371b22d95d2..a8821b23b945 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java @@ -21,6 +21,7 @@ import java.lang.reflect.Modifier; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentSkipListMap; +import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; import org.apache.yetus.audience.InterfaceAudience; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -178,14 +179,20 @@ private static final class HeaderSize { private byte a; } + private static final int ARRAY_OBJECT_INDEX_SCALE = + HBasePlatformDependent.arrayIndexScale(Object[].class); + + private static final int ARRAY_BYTE_INDEX_SCALE = + HBasePlatformDependent.arrayIndexScale(byte[].class); + public UnsafeLayout() { } @Override int headerSize() { try { - return (int) UnsafeAccess.theUnsafe - .objectFieldOffset(HeaderSize.class.getDeclaredField("a")); + return (int) HBasePlatformDependent.objectFieldOffset( + HeaderSize.class.getDeclaredField("a")); } catch (NoSuchFieldException | SecurityException e) { LOG.error(e.toString(), e); } @@ -194,21 +201,19 @@ int headerSize() { @Override int arrayHeaderSize() { - return UnsafeAccess.theUnsafe.arrayBaseOffset(byte[].class); + return HBasePlatformDependent.arrayBaseOffset(byte[].class); } @Override - @SuppressWarnings("static-access") int oopSize() { // Unsafe.addressSize() returns 8, even with CompressedOops. This is how many bytes each // element is allocated in an Object[]. - return UnsafeAccess.theUnsafe.ARRAY_OBJECT_INDEX_SCALE; + return ARRAY_OBJECT_INDEX_SCALE; } @Override - @SuppressWarnings("static-access") long sizeOfByteArray(int len) { - return align(ARRAY + len * UnsafeAccess.theUnsafe.ARRAY_BYTE_INDEX_SCALE); + return align(ARRAY + len * ARRAY_BYTE_INDEX_SCALE); } } @@ -216,7 +221,8 @@ private static MemoryLayout getMemoryLayout() { // Have a safeguard in case Unsafe estimate is wrong. This is static context, there is // no configuration, so we look at System property. String enabled = System.getProperty("hbase.memorylayout.use.unsafe"); - if (UnsafeAvailChecker.isAvailable() && (enabled == null || Boolean.parseBoolean(enabled))) { + if (HBasePlatformDependent.isUnsafeAvailable() && + (enabled == null || Boolean.parseBoolean(enabled))) { LOG.debug("Using Unsafe to estimate memory layout"); return new UnsafeLayout(); } diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java index 8e69b4ba5b69..85212393035b 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java @@ -17,26 +17,17 @@ */ package org.apache.hadoop.hbase.util; -import java.lang.reflect.Field; import java.nio.ByteBuffer; import java.nio.ByteOrder; -import java.security.AccessController; -import java.security.PrivilegedAction; import org.apache.yetus.audience.InterfaceAudience; import org.apache.yetus.audience.InterfaceStability; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; -import sun.misc.Unsafe; -import sun.nio.ch.DirectBuffer; +import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; +import org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent; @InterfaceAudience.Private @InterfaceStability.Evolving public final class UnsafeAccess { - private static final Logger LOG = LoggerFactory.getLogger(UnsafeAccess.class); - - public static final Unsafe theUnsafe; - /** The offset to the first element in a byte array. */ public static final long BYTE_ARRAY_BASE_OFFSET; @@ -48,22 +39,8 @@ public final class UnsafeAccess { // during a large copy static final long UNSAFE_COPY_THRESHOLD = 1024L * 1024L; static { - theUnsafe = (Unsafe) AccessController.doPrivileged(new PrivilegedAction() { - @Override - public Object run() { - try { - Field f = Unsafe.class.getDeclaredField("theUnsafe"); - f.setAccessible(true); - return f.get(null); - } catch (Throwable e) { - LOG.warn("sun.misc.Unsafe is not accessible", e); - } - return null; - } - }); - - if (theUnsafe != null) { - BYTE_ARRAY_BASE_OFFSET = theUnsafe.arrayBaseOffset(byte[].class); + if (HBasePlatformDependent.isUnsafeAvailable()) { + BYTE_ARRAY_BASE_OFFSET = HBasePlatformDependent.arrayBaseOffset(byte[].class); } else { BYTE_ARRAY_BASE_OFFSET = -1; } @@ -81,9 +58,10 @@ private UnsafeAccess() { */ public static short toShort(byte[] bytes, int offset) { if (LITTLE_ENDIAN) { - return Short.reverseBytes(theUnsafe.getShort(bytes, offset + BYTE_ARRAY_BASE_OFFSET)); + return Short + .reverseBytes(HBasePlatformDependent.getShort(bytes, offset + BYTE_ARRAY_BASE_OFFSET)); } else { - return theUnsafe.getShort(bytes, offset + BYTE_ARRAY_BASE_OFFSET); + return HBasePlatformDependent.getShort(bytes, offset + BYTE_ARRAY_BASE_OFFSET); } } @@ -95,9 +73,10 @@ public static short toShort(byte[] bytes, int offset) { */ public static int toInt(byte[] bytes, int offset) { if (LITTLE_ENDIAN) { - return Integer.reverseBytes(theUnsafe.getInt(bytes, offset + BYTE_ARRAY_BASE_OFFSET)); + return Integer + .reverseBytes(HBasePlatformDependent.getInt(bytes, offset + BYTE_ARRAY_BASE_OFFSET)); } else { - return theUnsafe.getInt(bytes, offset + BYTE_ARRAY_BASE_OFFSET); + return HBasePlatformDependent.getInt(bytes, offset + BYTE_ARRAY_BASE_OFFSET); } } @@ -109,9 +88,10 @@ public static int toInt(byte[] bytes, int offset) { */ public static long toLong(byte[] bytes, int offset) { if (LITTLE_ENDIAN) { - return Long.reverseBytes(theUnsafe.getLong(bytes, offset + BYTE_ARRAY_BASE_OFFSET)); + return Long + .reverseBytes(HBasePlatformDependent.getLong(bytes, offset + BYTE_ARRAY_BASE_OFFSET)); } else { - return theUnsafe.getLong(bytes, offset + BYTE_ARRAY_BASE_OFFSET); + return HBasePlatformDependent.getLong(bytes, offset + BYTE_ARRAY_BASE_OFFSET); } } @@ -127,7 +107,7 @@ public static int putShort(byte[] bytes, int offset, short val) { if (LITTLE_ENDIAN) { val = Short.reverseBytes(val); } - theUnsafe.putShort(bytes, offset + BYTE_ARRAY_BASE_OFFSET, val); + HBasePlatformDependent.putShort(bytes, offset + BYTE_ARRAY_BASE_OFFSET, val); return offset + Bytes.SIZEOF_SHORT; } @@ -142,7 +122,7 @@ public static int putInt(byte[] bytes, int offset, int val) { if (LITTLE_ENDIAN) { val = Integer.reverseBytes(val); } - theUnsafe.putInt(bytes, offset + BYTE_ARRAY_BASE_OFFSET, val); + HBasePlatformDependent.putInt(bytes, offset + BYTE_ARRAY_BASE_OFFSET, val); return offset + Bytes.SIZEOF_INT; } @@ -157,14 +137,15 @@ public static int putLong(byte[] bytes, int offset, long val) { if (LITTLE_ENDIAN) { val = Long.reverseBytes(val); } - theUnsafe.putLong(bytes, offset + BYTE_ARRAY_BASE_OFFSET, val); + HBasePlatformDependent.putLong(bytes, offset + BYTE_ARRAY_BASE_OFFSET, val); return offset + Bytes.SIZEOF_LONG; } // APIs to read primitive data from a ByteBuffer using Unsafe way /** * Reads a short value at the given buffer's offset considering it was written in big-endian - * format. nn * @return short value at offset + * format. + * @return short value at offset */ public static short toShort(ByteBuffer buf, int offset) { if (LITTLE_ENDIAN) { @@ -175,28 +156,32 @@ public static short toShort(ByteBuffer buf, int offset) { /** * Reads a short value at the given Object's offset considering it was written in big-endian - * format. nn * @return short value at offset + * format. + * @return short value at offset */ public static short toShort(Object ref, long offset) { if (LITTLE_ENDIAN) { - return Short.reverseBytes(theUnsafe.getShort(ref, offset)); + return Short.reverseBytes(HBasePlatformDependent.getShort(ref, offset)); } - return theUnsafe.getShort(ref, offset); + return HBasePlatformDependent.getShort(ref, offset); } /** - * Reads bytes at the given offset as a short value. nn * @return short value at offset + * Reads bytes at the given offset as a short value. + * @return short value at offset */ - static short getAsShort(ByteBuffer buf, int offset) { + private static short getAsShort(ByteBuffer buf, int offset) { if (buf.isDirect()) { - return theUnsafe.getShort(((DirectBuffer) buf).address() + offset); + return HBasePlatformDependent.getShort(directBufferAddress(buf) + offset); } - return theUnsafe.getShort(buf.array(), BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset); + return HBasePlatformDependent.getShort(buf.array(), + BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset); } /** * Reads an int value at the given buffer's offset considering it was written in big-endian - * format. nn * @return int value at offset + * format. + * @return int value at offset */ public static int toInt(ByteBuffer buf, int offset) { if (LITTLE_ENDIAN) { @@ -207,28 +192,34 @@ public static int toInt(ByteBuffer buf, int offset) { /** * Reads a int value at the given Object's offset considering it was written in big-endian format. - * nn * @return int value at offset + * @param ref + * @param offset + * @return int value at offset +>>>>>>> 6cef9e1602... HBASE-25465 Use javac --release option for supporting cross version compilation (#4164) */ public static int toInt(Object ref, long offset) { if (LITTLE_ENDIAN) { - return Integer.reverseBytes(theUnsafe.getInt(ref, offset)); + return Integer.reverseBytes(HBasePlatformDependent.getInt(ref, offset)); } - return theUnsafe.getInt(ref, offset); + return HBasePlatformDependent.getInt(ref, offset); } /** - * Reads bytes at the given offset as an int value. nn * @return int value at offset + * Reads bytes at the given offset as an int value. + * @return int value at offset */ - static int getAsInt(ByteBuffer buf, int offset) { + private static int getAsInt(ByteBuffer buf, int offset) { if (buf.isDirect()) { - return theUnsafe.getInt(((DirectBuffer) buf).address() + offset); + return HBasePlatformDependent.getInt(directBufferAddress(buf) + offset); } - return theUnsafe.getInt(buf.array(), BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset); + return HBasePlatformDependent.getInt(buf.array(), + BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset); } /** * Reads a long value at the given buffer's offset considering it was written in big-endian - * format. nn * @return long value at offset + * format. + * @return long value at offset */ public static long toLong(ByteBuffer buf, int offset) { if (LITTLE_ENDIAN) { @@ -239,23 +230,49 @@ public static long toLong(ByteBuffer buf, int offset) { /** * Reads a long value at the given Object's offset considering it was written in big-endian - * format. nn * @return long value at offset + * format. + * @return long value at offset */ public static long toLong(Object ref, long offset) { if (LITTLE_ENDIAN) { - return Long.reverseBytes(theUnsafe.getLong(ref, offset)); + return Long.reverseBytes(HBasePlatformDependent.getLong(ref, offset)); + } + return HBasePlatformDependent.getLong(ref, offset); + } + + /** + * Reads bytes at the given offset as a long value. + * @return long value at offset + */ + private static long getAsLong(ByteBuffer buf, int offset) { + if (buf.isDirect()) { + return HBasePlatformDependent.getLong(directBufferAddress(buf) + offset); } - return theUnsafe.getLong(ref, offset); + return HBasePlatformDependent.getLong(buf.array(), + BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset); } /** - * Reads bytes at the given offset as a long value. nn * @return long value at offset + * Returns the byte at the given offset + * @param buf the buffer to read + * @param offset the offset at which the byte has to be read + * @return the byte at the given offset */ - static long getAsLong(ByteBuffer buf, int offset) { + public static byte toByte(ByteBuffer buf, int offset) { if (buf.isDirect()) { - return theUnsafe.getLong(((DirectBuffer) buf).address() + offset); + return HBasePlatformDependent.getByte(directBufferAddress(buf) + offset); + } else { + return HBasePlatformDependent.getByte(buf.array(), + BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset); } - return theUnsafe.getLong(buf.array(), BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset); + } + + /** + * Returns the byte at the given offset of the object + * @return the byte at the given offset + */ + public static byte toByte(Object ref, long offset) { + return HBasePlatformDependent.getByte(ref, offset); } /** @@ -270,9 +287,10 @@ public static int putInt(ByteBuffer buf, int offset, int val) { val = Integer.reverseBytes(val); } if (buf.isDirect()) { - theUnsafe.putInt(((DirectBuffer) buf).address() + offset, val); + HBasePlatformDependent.putInt(directBufferAddress(buf) + offset, val); } else { - theUnsafe.putInt(buf.array(), offset + buf.arrayOffset() + BYTE_ARRAY_BASE_OFFSET, val); + HBasePlatformDependent.putInt(buf.array(), + offset + buf.arrayOffset() + BYTE_ARRAY_BASE_OFFSET, val); } return offset + Bytes.SIZEOF_INT; } @@ -285,7 +303,7 @@ public static void copy(byte[] src, int srcOffset, ByteBuffer dest, int destOffs long destAddress = destOffset; Object destBase = null; if (dest.isDirect()) { - destAddress = destAddress + ((DirectBuffer) dest).address(); + destAddress = destAddress + directBufferAddress(dest); } else { destAddress = destAddress + BYTE_ARRAY_BASE_OFFSET + dest.arrayOffset(); destBase = dest.array(); @@ -297,7 +315,7 @@ public static void copy(byte[] src, int srcOffset, ByteBuffer dest, int destOffs private static void unsafeCopy(Object src, long srcAddr, Object dst, long destAddr, long len) { while (len > 0) { long size = (len > UNSAFE_COPY_THRESHOLD) ? UNSAFE_COPY_THRESHOLD : len; - theUnsafe.copyMemory(src, srcAddr, dst, destAddr, size); + HBasePlatformDependent.copyMemory(src, srcAddr, dst, destAddr, size); len -= size; srcAddr += size; destAddr += size; @@ -306,13 +324,22 @@ private static void unsafeCopy(Object src, long srcAddr, Object dst, long destAd /** * Copies specified number of bytes from given offset of {@code src} ByteBuffer to the +<<<<<<< HEAD * {@code dest} array. nnnnn +======= + * {@code dest} array. + * @param src source buffer + * @param srcOffset offset into source buffer + * @param dest destination array + * @param destOffset offset into destination buffer + * @param length length of data to copy +>>>>>>> 6cef9e1602... HBASE-25465 Use javac --release option for supporting cross version compilation (#4164) */ public static void copy(ByteBuffer src, int srcOffset, byte[] dest, int destOffset, int length) { long srcAddress = srcOffset; Object srcBase = null; if (src.isDirect()) { - srcAddress = srcAddress + ((DirectBuffer) src).address(); + srcAddress = srcAddress + directBufferAddress(src); } else { srcAddress = srcAddress + BYTE_ARRAY_BASE_OFFSET + src.arrayOffset(); srcBase = src.array(); @@ -323,20 +350,25 @@ public static void copy(ByteBuffer src, int srcOffset, byte[] dest, int destOffs /** * Copies specified number of bytes from given offset of {@code src} buffer into the {@code dest} - * buffer. nnnnn + * buffer. + * @param src source buffer + * @param srcOffset offset into source buffer + * @param dest destination buffer + * @param destOffset offset into destination buffer + * @param length length of data to copy */ public static void copy(ByteBuffer src, int srcOffset, ByteBuffer dest, int destOffset, int length) { long srcAddress, destAddress; Object srcBase = null, destBase = null; if (src.isDirect()) { - srcAddress = srcOffset + ((DirectBuffer) src).address(); + srcAddress = srcOffset + directBufferAddress(src); } else { srcAddress = (long) srcOffset + src.arrayOffset() + BYTE_ARRAY_BASE_OFFSET; srcBase = src.array(); } if (dest.isDirect()) { - destAddress = destOffset + ((DirectBuffer) dest).address(); + destAddress = destOffset + directBufferAddress(dest); } else { destAddress = destOffset + BYTE_ARRAY_BASE_OFFSET + dest.arrayOffset(); destBase = dest.array(); @@ -357,9 +389,10 @@ public static int putShort(ByteBuffer buf, int offset, short val) { val = Short.reverseBytes(val); } if (buf.isDirect()) { - theUnsafe.putShort(((DirectBuffer) buf).address() + offset, val); + HBasePlatformDependent.putShort(directBufferAddress(buf) + offset, val); } else { - theUnsafe.putShort(buf.array(), BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset, val); + HBasePlatformDependent.putShort(buf.array(), + BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset, val); } return offset + Bytes.SIZEOF_SHORT; } @@ -376,9 +409,10 @@ public static int putLong(ByteBuffer buf, int offset, long val) { val = Long.reverseBytes(val); } if (buf.isDirect()) { - theUnsafe.putLong(((DirectBuffer) buf).address() + offset, val); + HBasePlatformDependent.putLong(directBufferAddress(buf) + offset, val); } else { - theUnsafe.putLong(buf.array(), BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset, val); + HBasePlatformDependent.putLong(buf.array(), + BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset, val); } return offset + Bytes.SIZEOF_LONG; } @@ -392,31 +426,21 @@ public static int putLong(ByteBuffer buf, int offset, long val) { */ public static int putByte(ByteBuffer buf, int offset, byte b) { if (buf.isDirect()) { - theUnsafe.putByte(((DirectBuffer) buf).address() + offset, b); + HBasePlatformDependent.putByte(directBufferAddress(buf) + offset, b); } else { - theUnsafe.putByte(buf.array(), BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset, b); + HBasePlatformDependent.putByte(buf.array(), + BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset, b); } return offset + 1; } - /** - * Returns the byte at the given offset - * @param buf the buffer to read - * @param offset the offset at which the byte has to be read - * @return the byte at the given offset - */ - public static byte toByte(ByteBuffer buf, int offset) { - if (buf.isDirect()) { - return theUnsafe.getByte(((DirectBuffer) buf).address() + offset); - } else { - return theUnsafe.getByte(buf.array(), BYTE_ARRAY_BASE_OFFSET + buf.arrayOffset() + offset); - } + + public static long directBufferAddress(ByteBuffer buf) { + return PlatformDependent.directBufferAddress(buf); } - /** - * Returns the byte at the given offset of the object nn * @return the byte at the given offset - */ - public static byte toByte(Object ref, long offset) { - return theUnsafe.getByte(ref, offset); + public static void freeDirectBuffer(ByteBuffer buffer) { + // here we just use the method in netty + PlatformDependent.freeDirectBuffer(buffer); } } diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java deleted file mode 100644 index 00f2c0d8cf36..000000000000 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java +++ /dev/null @@ -1,189 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.hadoop.hbase.util; - -import java.lang.reflect.Field; -import java.lang.reflect.Method; -import java.security.AccessController; -import java.security.PrivilegedAction; -import org.apache.yetus.audience.InterfaceAudience; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -@InterfaceAudience.Private -public class UnsafeAvailChecker { - - private static final String CLASS_NAME = "sun.misc.Unsafe"; - private static final Logger LOG = LoggerFactory.getLogger(UnsafeAvailChecker.class); - private static boolean avail = false; - private static boolean unaligned = false; - - static { - avail = AccessController.doPrivileged(new PrivilegedAction() { - @Override - public Boolean run() { - try { - Class clazz = Class.forName(CLASS_NAME); - Field f = clazz.getDeclaredField("theUnsafe"); - f.setAccessible(true); - Object theUnsafe = f.get(null); - if (theUnsafe == null) { - LOG.warn("Could not get static instance from sun.misc.Unsafe"); - return false; - } - // Check for availability of all methods used by UnsafeAccess - Method m; - try { - m = clazz.getDeclaredMethod("arrayBaseOffset", Class.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing arrayBaseOffset(Class)"); - return false; - } - m = clazz.getDeclaredMethod("copyMemory", Object.class, long.class, Object.class, - long.class, long.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing copyMemory(Object,long,Object,long,long)"); - return false; - } - m = clazz.getDeclaredMethod("getByte", Object.class, long.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing getByte(Object,long)"); - return false; - } - m = clazz.getDeclaredMethod("getShort", long.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing getShort(long)"); - return false; - } - m = clazz.getDeclaredMethod("getShort", Object.class, long.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing getShort(Object,long)"); - return false; - } - m = clazz.getDeclaredMethod("getInt", long.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing getInt(long)"); - return false; - } - m = clazz.getDeclaredMethod("getInt", Object.class, long.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing getInt(Object,long)"); - return false; - } - m = clazz.getDeclaredMethod("getLong", long.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing getLong(long)"); - return false; - } - m = clazz.getDeclaredMethod("getLong", Object.class, long.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing getLong(Object,long)"); - return false; - } - m = clazz.getDeclaredMethod("putByte", long.class, byte.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing putByte(long,byte)"); - return false; - } - m = clazz.getDeclaredMethod("putByte", Object.class, long.class, byte.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing putByte(Object,long,byte)"); - return false; - } - m = clazz.getDeclaredMethod("putShort", long.class, short.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing putShort(long,short)"); - return false; - } - m = clazz.getDeclaredMethod("putShort", Object.class, long.class, short.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing putShort(Object,long,short)"); - return false; - } - m = clazz.getDeclaredMethod("putInt", long.class, int.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing putInt(long,int)"); - return false; - } - m = clazz.getDeclaredMethod("putInt", Object.class, long.class, int.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing putInt(Object,long,int)"); - return false; - } - m = clazz.getDeclaredMethod("putLong", long.class, long.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing putLong(long,long)"); - return false; - } - m = clazz.getDeclaredMethod("putLong", Object.class, long.class, long.class); - if (m == null) { - LOG.warn("sun.misc.Unsafe is missing putLong(Object,long,long)"); - return false; - } - // theUnsafe is accessible and all methods are available - return true; - } catch (Throwable e) { - LOG.warn("sun.misc.Unsafe is missing one or more required methods", e); - } - } catch (Throwable e) { - LOG.warn("sun.misc.Unsafe is not available/accessible", e); - } - return false; - } - }); - // When Unsafe itself is not available/accessible consider unaligned as false. - if (avail) { - String arch = System.getProperty("os.arch"); - if ("ppc64".equals(arch) || "ppc64le".equals(arch) || "aarch64".equals(arch)) { - // java.nio.Bits.unaligned() wrongly returns false on ppc (JDK-8165231), - unaligned = true; - } else { - try { - // Using java.nio.Bits#unaligned() to check for unaligned-access capability - Class clazz = Class.forName("java.nio.Bits"); - Method m = clazz.getDeclaredMethod("unaligned"); - m.setAccessible(true); - unaligned = (Boolean) m.invoke(null); - } catch (Exception e) { - LOG.warn("java.nio.Bits#unaligned() check failed." - + "Unsafe based read/write of primitive types won't be used", e); - } - } - } - } - - /** - * @return true when running JVM is having sun's Unsafe package available in it and it is - * accessible. - */ - public static boolean isAvailable() { - return avail; - } - - /** - * @return true when running JVM is having sun's Unsafe package available in it and underlying - * system having unaligned-access capability. - */ - public static boolean unaligned() { - return unaligned; - } - - private UnsafeAvailChecker() { - // private constructor to avoid instantiation - } -} diff --git a/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteBufferUtils.java b/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteBufferUtils.java index 6bf633ed62d5..815cb9d6b63e 100644 --- a/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteBufferUtils.java +++ b/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteBufferUtils.java @@ -49,6 +49,7 @@ import org.apache.hadoop.hbase.HConstants; import org.apache.hadoop.hbase.testclassification.MediumTests; import org.apache.hadoop.hbase.testclassification.MiscTests; +import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; import org.apache.hadoop.io.WritableUtils; import org.junit.AfterClass; import org.junit.Before; @@ -106,14 +107,14 @@ static void disableUnsafe() throws Exception { } static void detectAvailabilityOfUnsafe() throws Exception { - if (ByteBufferUtils.UNSAFE_AVAIL != UnsafeAvailChecker.isAvailable()) { - setUnsafe(UNSAFE_AVAIL_NAME, UnsafeAvailChecker.isAvailable()); + if (ByteBufferUtils.UNSAFE_AVAIL != HBasePlatformDependent.isUnsafeAvailable()) { + setUnsafe(UNSAFE_AVAIL_NAME, HBasePlatformDependent.isUnsafeAvailable()); } - if (ByteBufferUtils.UNSAFE_UNALIGNED != UnsafeAvailChecker.unaligned()) { - setUnsafe(UNSAFE_UNALIGNED_NAME, UnsafeAvailChecker.unaligned()); + if (ByteBufferUtils.UNSAFE_UNALIGNED != HBasePlatformDependent.unaligned()) { + setUnsafe(UNSAFE_UNALIGNED_NAME, HBasePlatformDependent.unaligned()); } - assertEquals(ByteBufferUtils.UNSAFE_AVAIL, UnsafeAvailChecker.isAvailable()); - assertEquals(ByteBufferUtils.UNSAFE_UNALIGNED, UnsafeAvailChecker.unaligned()); + assertEquals(ByteBufferUtils.UNSAFE_AVAIL, HBasePlatformDependent.isUnsafeAvailable()); + assertEquals(ByteBufferUtils.UNSAFE_UNALIGNED, HBasePlatformDependent.unaligned()); } public TestByteBufferUtils(boolean useUnsafeIfPossible) throws Exception { diff --git a/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java b/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java index 84637bb7ad10..8560863dae9a 100644 --- a/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java +++ b/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java @@ -37,6 +37,7 @@ import org.apache.hadoop.hbase.HBaseClassTestRule; import org.apache.hadoop.hbase.testclassification.MediumTests; import org.apache.hadoop.hbase.testclassification.MiscTests; +import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; import org.apache.hadoop.io.WritableUtils; import org.junit.Assert; import org.junit.ClassRule; @@ -79,7 +80,7 @@ private static void testShort(boolean unsafe) throws Exception { assertEquals(Bytes.toShort(bytes, 0, bytes.length), n); } } finally { - setUnsafe(UnsafeAvailChecker.unaligned()); + setUnsafe(HBasePlatformDependent.unaligned()); } } diff --git a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestRESTServerSSL.java b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestRESTServerSSL.java index e5d94dd5ab78..5731dd94fc66 100644 --- a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestRESTServerSSL.java +++ b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestRESTServerSSL.java @@ -20,6 +20,7 @@ import static org.junit.Assert.assertEquals; import java.io.File; +import java.lang.reflect.Method; import java.security.KeyPair; import java.security.cert.X509Certificate; import java.util.Optional; @@ -39,7 +40,8 @@ import org.junit.ClassRule; import org.junit.Test; import org.junit.experimental.categories.Category; -import sun.security.x509.AlgorithmId; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; @Category({ RestTests.class, MediumTests.class }) public class TestRESTServerSSL { @@ -48,6 +50,8 @@ public class TestRESTServerSSL { public static final HBaseClassTestRule CLASS_RULE = HBaseClassTestRule.forClass(TestRESTServerSSL.class); + private static final Logger LOG = LoggerFactory.getLogger(TestRESTServerSSL.class); + private static final String KEY_STORE_PASSWORD = "myKSPassword"; private static final String TRUST_STORE_PASSWORD = "myTSPassword"; @@ -57,12 +61,23 @@ public class TestRESTServerSSL { private static File keyDir; private Configuration conf; + // Workaround for jdk8 292 bug. See https://github.com/bcgit/bc-java/issues/941 + // Below is a workaround described in above URL. Issue fingered first in comments in + // HBASE-25920 Support Hadoop 3.3.1 + private static void initializeAlgorithmId() { + try { + Class algoId = Class.forName("sun.security.x509.AlgorithmId"); + Method method = algoId.getMethod("get", String.class); + method.setAccessible(true); + method.invoke(null, "PBEWithSHA1AndDESede"); + } catch (Exception e) { + LOG.warn("failed to initialize AlgorithmId", e); + } + } + @BeforeClass public static void beforeClass() throws Exception { - // Workaround for jdk8 252 bug. See https://github.com/bcgit/bc-java/issues/941 - // Below is a workaround described in above URL. Issue fingered first in comments in - // HBASE-25920 Support Hadoop 3.3.1 - AlgorithmId.get("PBEWithSHA1AndDESede"); + initializeAlgorithmId(); keyDir = initKeystoreDir(); KeyPair keyPair = KeyStoreTestUtil.generateKeyPair("RSA"); X509Certificate serverCertificate = diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java index dcf7270dabb5..c9cc4d257501 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java @@ -156,6 +156,7 @@ import org.apache.hadoop.hbase.security.access.ZKPermissionWatcher; import org.apache.hadoop.hbase.trace.SpanReceiverHost; import org.apache.hadoop.hbase.trace.TraceUtil; +import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; import org.apache.hadoop.hbase.util.Addressing; import org.apache.hadoop.hbase.util.Bytes; import org.apache.hadoop.hbase.util.CommonFSUtils; @@ -192,7 +193,6 @@ import org.apache.zookeeper.KeeperException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import sun.misc.Signal; import org.apache.hbase.thirdparty.com.google.common.base.Preconditions; import org.apache.hbase.thirdparty.com.google.common.base.Throwables; @@ -735,7 +735,7 @@ protected String getUseThisHostnameInstead(Configuration conf) throws IOExceptio */ private static void setupWindows(final Configuration conf, ConfigurationManager cm) { if (!SystemUtils.IS_OS_WINDOWS) { - Signal.handle(new Signal("HUP"), signal -> { + HBasePlatformDependent.handle("HUP", (number, name) -> { conf.reloadConfiguration(); cm.notifyAllObservers(conf); }); diff --git a/pom.xml b/pom.xml index af5e958ca36f..e3b04287a08e 100755 --- a/pom.xml +++ b/pom.xml @@ -535,6 +535,7 @@ yyyy-MM-dd'T'HH:mm ${maven.build.timestamp} 1.8 + 8 3.0.4 ${compileSource} @@ -563,8 +564,8 @@ 4.5.13 4.4.13 3.2.6 - 2.10.1 - 2.10.1 + 2.13.1 + 2.13.1 2.3.1 3.1.0 2.1.1 @@ -624,7 +625,7 @@ 2.12 1.0.1 2.22.2 - 4.0.1 + 4.1.0 @@ -1389,6 +1390,11 @@ hbase-shaded-jackson-jaxrs-json-provider ${hbase-thirdparty.version} + + org.apache.hbase.thirdparty + hbase-unsafe + ${hbase-thirdparty.version} + com.sun.xml.ws jaxws-ri @@ -2611,6 +2617,7 @@ [1.11,) + ${releaseTarget} --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED ${hbase-surefire.argLine} From db90620e91a5d726819be42609c1025474f4fee2 Mon Sep 17 00:00:00 2001 From: Nick Dimiduk Date: Fri, 18 Mar 2022 16:26:30 +0100 Subject: [PATCH 3/4] HBASE-26855 Delete unnecessary dependency on jaxb-runtime jar (#4236) Signed-off-by: Duo Zhang --- hbase-rest/pom.xml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/hbase-rest/pom.xml b/hbase-rest/pom.xml index 808639c99c81..13dd9529ee16 100644 --- a/hbase-rest/pom.xml +++ b/hbase-rest/pom.xml @@ -515,15 +515,6 @@ org.apache.hadoop hadoop-auth - - - org.glassfish.jaxb - jaxb-runtime - 2.3.2 - From 17be48f86c8e878f67e5f7d5296aadb14d69c7f9 Mon Sep 17 00:00:00 2001 From: Viraj Jasani Date: Tue, 17 May 2022 10:27:11 -0700 Subject: [PATCH 4/4] spotless apply --- .../org/apache/hadoop/hbase/util/Bytes.java | 13 ++++---- .../apache/hadoop/hbase/util/ClassSize.java | 10 +++--- .../hadoop/hbase/util/UnsafeAccess.java | 31 +++++++------------ .../hbase/rest/TestMultiRowResource.java | 2 +- .../rest/TestNamespacesInstanceResource.java | 2 +- .../hadoop/hbase/rest/TestTableScan.java | 2 +- .../hbase/rest/TestVersionResource.java | 2 +- .../hbase/io/hfile/LruCachedBlockQueue.java | 6 ++-- .../io/hfile/bucket/CachedEntryQueue.java | 6 ++-- 9 files changed, 35 insertions(+), 39 deletions(-) diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java index 75b57867276e..d405bb57b919 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java @@ -1427,7 +1427,8 @@ int putShort(byte[] bytes, int offset, short val) { protected static final class UnsafeConverter extends Converter { - public UnsafeConverter() {} + public UnsafeConverter() { + } static { if (!UNSAFE_UNALIGNED) { @@ -1475,11 +1476,11 @@ int putShort(byte[] bytes, int offset, short val) { } /** - * Provides a lexicographical comparer implementation; either a Java - * implementation or a faster implementation based on {@code Unsafe}. - * - *

Uses reflection to gracefully fall back to the Java implementation if - * {@code Unsafe} isn't available. + * Provides a lexicographical comparer implementation; either a Java implementation or a faster + * implementation based on {@code Unsafe}. + *

+ * Uses reflection to gracefully fall back to the Java implementation if {@code Unsafe} isn't + * available. */ @InterfaceAudience.Private static class LexicographicalComparerHolder { diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java index a8821b23b945..6ac3edbc2d77 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java @@ -191,8 +191,8 @@ public UnsafeLayout() { @Override int headerSize() { try { - return (int) HBasePlatformDependent.objectFieldOffset( - HeaderSize.class.getDeclaredField("a")); + return (int) HBasePlatformDependent + .objectFieldOffset(HeaderSize.class.getDeclaredField("a")); } catch (NoSuchFieldException | SecurityException e) { LOG.error(e.toString(), e); } @@ -221,8 +221,10 @@ private static MemoryLayout getMemoryLayout() { // Have a safeguard in case Unsafe estimate is wrong. This is static context, there is // no configuration, so we look at System property. String enabled = System.getProperty("hbase.memorylayout.use.unsafe"); - if (HBasePlatformDependent.isUnsafeAvailable() && - (enabled == null || Boolean.parseBoolean(enabled))) { + if ( + HBasePlatformDependent.isUnsafeAvailable() + && (enabled == null || Boolean.parseBoolean(enabled)) + ) { LOG.debug("Using Unsafe to estimate memory layout"); return new UnsafeLayout(); } diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java index 85212393035b..40bd7baa4b24 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java @@ -19,9 +19,10 @@ import java.nio.ByteBuffer; import java.nio.ByteOrder; +import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; import org.apache.yetus.audience.InterfaceAudience; import org.apache.yetus.audience.InterfaceStability; -import org.apache.hadoop.hbase.unsafe.HBasePlatformDependent; + import org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent; @InterfaceAudience.Private @@ -192,10 +193,7 @@ public static int toInt(ByteBuffer buf, int offset) { /** * Reads a int value at the given Object's offset considering it was written in big-endian format. - * @param ref - * @param offset - * @return int value at offset ->>>>>>> 6cef9e1602... HBASE-25465 Use javac --release option for supporting cross version compilation (#4164) + * nn * @return int value at offset */ public static int toInt(Object ref, long offset) { if (LITTLE_ENDIAN) { @@ -254,7 +252,7 @@ private static long getAsLong(ByteBuffer buf, int offset) { /** * Returns the byte at the given offset - * @param buf the buffer to read + * @param buf the buffer to read * @param offset the offset at which the byte has to be read * @return the byte at the given offset */ @@ -324,16 +322,12 @@ private static void unsafeCopy(Object src, long srcAddr, Object dst, long destAd /** * Copies specified number of bytes from given offset of {@code src} ByteBuffer to the -<<<<<<< HEAD - * {@code dest} array. nnnnn -======= * {@code dest} array. - * @param src source buffer - * @param srcOffset offset into source buffer - * @param dest destination array + * @param src source buffer + * @param srcOffset offset into source buffer + * @param dest destination array * @param destOffset offset into destination buffer - * @param length length of data to copy ->>>>>>> 6cef9e1602... HBASE-25465 Use javac --release option for supporting cross version compilation (#4164) + * @param length length of data to copy */ public static void copy(ByteBuffer src, int srcOffset, byte[] dest, int destOffset, int length) { long srcAddress = srcOffset; @@ -351,11 +345,11 @@ public static void copy(ByteBuffer src, int srcOffset, byte[] dest, int destOffs /** * Copies specified number of bytes from given offset of {@code src} buffer into the {@code dest} * buffer. - * @param src source buffer - * @param srcOffset offset into source buffer - * @param dest destination buffer + * @param src source buffer + * @param srcOffset offset into source buffer + * @param dest destination buffer * @param destOffset offset into destination buffer - * @param length length of data to copy + * @param length length of data to copy */ public static void copy(ByteBuffer src, int srcOffset, ByteBuffer dest, int destOffset, int length) { @@ -434,7 +428,6 @@ public static int putByte(ByteBuffer buf, int offset, byte b) { return offset + 1; } - public static long directBufferAddress(ByteBuffer buf) { return PlatformDependent.directBufferAddress(buf); } diff --git a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestMultiRowResource.java b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestMultiRowResource.java index f795b2cb9322..61734734871d 100644 --- a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestMultiRowResource.java +++ b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestMultiRowResource.java @@ -55,7 +55,7 @@ import org.apache.hbase.thirdparty.com.fasterxml.jackson.jaxrs.json.JacksonJaxbJsonProvider; import org.apache.hbase.thirdparty.javax.ws.rs.core.MediaType; -@Category({RestTests.class, MediumTests.class}) +@Category({ RestTests.class, MediumTests.class }) @RunWith(Parameterized.class) public class TestMultiRowResource { @ClassRule diff --git a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java index 3515f553edf3..2d09ae0da4a2 100644 --- a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java +++ b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java @@ -62,7 +62,7 @@ import org.apache.hbase.thirdparty.com.fasterxml.jackson.jaxrs.json.JacksonJaxbJsonProvider; import org.apache.hbase.thirdparty.javax.ws.rs.core.MediaType; -@Category({RestTests.class, MediumTests.class}) +@Category({ RestTests.class, MediumTests.class }) public class TestNamespacesInstanceResource { @ClassRule public static final HBaseClassTestRule CLASS_RULE = diff --git a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestTableScan.java b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestTableScan.java index c4234db99ba0..2e7a4af13b7e 100644 --- a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestTableScan.java +++ b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestTableScan.java @@ -74,7 +74,7 @@ import org.apache.hbase.thirdparty.com.fasterxml.jackson.jaxrs.json.JacksonJaxbJsonProvider; import org.apache.hbase.thirdparty.javax.ws.rs.core.MediaType; -@Category({RestTests.class, MediumTests.class}) +@Category({ RestTests.class, MediumTests.class }) public class TestTableScan { @ClassRule public static final HBaseClassTestRule CLASS_RULE = diff --git a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestVersionResource.java b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestVersionResource.java index f799fd54efc8..542d39ada9b9 100644 --- a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestVersionResource.java +++ b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestVersionResource.java @@ -47,7 +47,7 @@ import org.apache.hbase.thirdparty.com.fasterxml.jackson.jaxrs.json.JacksonJaxbJsonProvider; import org.apache.hbase.thirdparty.javax.ws.rs.core.MediaType; -@Category({RestTests.class, MediumTests.class}) +@Category({ RestTests.class, MediumTests.class }) public class TestVersionResource { @ClassRule diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java index 99d4639e9775..8e45cb772d22 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java @@ -67,9 +67,9 @@ public LruCachedBlockQueue(long maxSize, long blockSize) { * @param cb block to try to add to the queue */ @edu.umd.cs.findbugs.annotations.SuppressWarnings( - value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE", - justification = "head can not be null as heapSize is greater than maxSize," - + " which means we have something in the queue") + value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE", + justification = "head can not be null as heapSize is greater than maxSize," + + " which means we have something in the queue") public void add(LruCachedBlock cb) { if (heapSize < maxSize) { queue.add(cb); diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/CachedEntryQueue.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/CachedEntryQueue.java index c6d6ac4ddc2d..daa25cee1de2 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/CachedEntryQueue.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/CachedEntryQueue.java @@ -70,9 +70,9 @@ public CachedEntryQueue(long maxSize, long blockSize) { * @param entry a bucket entry with key to try to add to the queue */ @edu.umd.cs.findbugs.annotations.SuppressWarnings( - value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE", - justification = "head can not be null as cacheSize is greater than maxSize," - + " which means we have something in the queue") + value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE", + justification = "head can not be null as cacheSize is greater than maxSize," + + " which means we have something in the queue") public void add(Map.Entry entry) { if (cacheSize < maxSize) { queue.add(entry);