-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28303 Interrupt cache prefetch thread when a heap usage threshold is reached #5615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
taklwu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| double total = Runtime.getRuntime().maxMemory(); | ||
| double available = Runtime.getRuntime().freeMemory(); | ||
| double usedRatio = 1d - (available / total); | ||
| return heapUsageThreshold > usedRatio; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] I found the hbase has of MemorySizeUtil.safeGetHeapMemoryUsage(); in region server to get heap usage and other place with a single instance, although I think it's still using these two methods at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem to get accurate values, specially when running in the UTs.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
recheck |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Change-Id: I061961d69830fe25f9da5e4bdf7bab58129d94c4
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Change-Id: I475c889dd38582dc971e6b41a433b86ad209b3f1
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…ld is reached (#5615) Signed-off-by: Tak Lon (Stephen) Wu <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>
…ld is reached (#5615) Signed-off-by: Tak Lon (Stephen) Wu <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>
No description provided.