Skip to content

Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2.5 #6100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2024
Merged

Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2.5 #6100

merged 1 commit into from
Jul 24, 2024

Conversation

@ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Jul 19, 2024

No description provided.

@ndimiduk ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jul 19, 2024
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
pankaj72981
pankaj72981 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@pankaj72981 pankaj72981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@ndimiduk @charlesconnell
HBASE-28716 Users of QuotaRetriever should pass an existing connection (
5efba33 
apache#6065)

Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Pankaj Kumar <[email protected]>
Co-authored-by: Charles Connell <[email protected]>
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

Apache-HBase commented Jul 24, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 9s branch-2.5 passed
+1 💚 compile 3m 26s branch-2.5 passed
+1 💚 checkstyle 0m 55s branch-2.5 passed
+1 💚 spotbugs 2m 26s branch-2.5 passed
+1 💚 spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 2m 56s the patch passed
+1 💚 compile 3m 22s the patch passed
+1 💚 javac 3m 22s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 54s the patch passed
+1 💚 spotbugs 2m 41s the patch passed
+1 💚 hadoopcheck 22m 10s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚 spotless 0m 47s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 19s The patch does not generate ASF License warnings.
47m 3s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6100
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux c6ce3545f2c0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 5efba33
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 24, 2024

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 49s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
-1 ❌ mvninstall 0m 42s /branch-mvninstall-root.txt root in branch-2.5 failed.
-1 ❌ compile 0m 10s /branch-compile-hbase-client.txt hbase-client in branch-2.5 failed.
-1 ❌ compile 0m 14s /branch-compile-hbase-server.txt hbase-server in branch-2.5 failed.
-0 ⚠️ javadoc 0m 6s /branch-javadoc-hbase-client.txt hbase-client in branch-2.5 failed.
-0 ⚠️ javadoc 0m 7s /branch-javadoc-hbase-server.txt hbase-server in branch-2.5 failed.
+1 💚 shadedjars 5m 13s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
+1 💚 mvninstall 2m 19s the patch passed
+1 💚 compile 1m 1s the patch passed
+1 💚 javac 1m 1s the patch passed
-0 ⚠️ javadoc 0m 21s /results-javadoc-javadoc-hbase-client.txt hbase-client generated 31 new + 0 unchanged - 0 fixed = 31 total (was 0)
-0 ⚠️ javadoc 0m 31s /results-javadoc-javadoc-hbase-server.txt hbase-server generated 18 new + 0 unchanged - 0 fixed = 18 total (was 0)
+1 💚 shadedjars 5m 38s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 7m 52s hbase-client in the patch passed.
+1 💚 unit 196m 23s hbase-server in the patch passed.
226m 7s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6100
Optional Tests javac javadoc unit compile shadedjars
uname Linux 4c8949478d2b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 5efba33
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/testReport/
Max. process+thread count 4057 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 24, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 56s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 3m 20s branch-2.5 passed
+1 💚 compile 1m 28s branch-2.5 passed
+1 💚 javadoc 0m 56s branch-2.5 passed
+1 💚 shadedjars 6m 9s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 compile 1m 19s the patch passed
+1 💚 javac 1m 19s the patch passed
+1 💚 javadoc 0m 56s the patch passed
+1 💚 shadedjars 5m 41s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 8m 14s hbase-client in the patch passed.
+1 💚 unit 203m 21s hbase-server in the patch passed.
240m 44s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6100
Optional Tests javac javadoc unit compile shadedjars
uname Linux 9febc24dc461 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 5efba33
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/testReport/
Max. process+thread count 4252 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 24, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for branch
+1 💚 mvninstall 2m 50s branch-2.5 passed
+1 💚 compile 1m 21s branch-2.5 passed
+1 💚 javadoc 0m 51s branch-2.5 passed
+1 💚 shadedjars 5m 5s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 2m 50s the patch passed
+1 💚 compile 1m 20s the patch passed
+1 💚 javac 1m 20s the patch passed
+1 💚 javadoc 0m 47s the patch passed
+1 💚 shadedjars 5m 5s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 8m 4s hbase-client in the patch passed.
+1 💚 unit 211m 3s hbase-server in the patch passed.
245m 26s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6100
Optional Tests javac javadoc unit compile shadedjars
uname Linux 10dacae22d9b 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 5efba33
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/testReport/
Max. process+thread count 4279 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
Copy link
Member Author

ndimiduk commented Jul 24, 2024

I'm not sure what's going on with jenkins. My local builds of branch-2.5 with jd8 are fine, with and without this patch. FYI @apurtell

@ndimiduk ndimiduk merged commit 5cf4e21 into apache:branch-2.5 Jul 24, 2024
@ndimiduk ndimiduk deleted the 28716-branch-2.5 branch July 24, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pankaj72981 pankaj72981 pankaj72981 approved these changes

Assignees

No one assigned

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk @Apache-HBase @pankaj72981