-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28924 Create the start time right before creating the reader to calculate elapsedTime in testPrefetchWithDelay #6371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lapsedTime in testPrefetchWithDelay
|
💔 -1 overall
This message was automatically generated. |
apurtell
approved these changes
Oct 17, 2024
Contributor
|
@gvprathyusha6 Approved. The spotbugs warning is unrelated. |
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Oct 18, 2024
Contributor
Raised HBASE-28927 for spotbugs, introduced in HBASE-28432. Sorry for the noise ! |
asfgit
pushed a commit
that referenced
this pull request
Oct 18, 2024
…lapsedTime in testPrefetchWithDelay (#6371) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Oct 18, 2024
…lapsedTime in testPrefetchWithDelay (#6371) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
Contributor
|
Hi @apurtell just a heads up. Seems JIRA# somehow got lost during merge of this PR |
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Oct 22, 2024
…lapsedTime in testPrefetchWithDelay (apache#6371) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Oct 22, 2024
…lapsedTime in testPrefetchWithDelay (apache#6371) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Oct 22, 2024
…6371) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Oct 22, 2024
…6371) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Oct 22, 2024
…6371) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test currently fails intermittently in master branch, as startime is post reader creation
Elapsed time is sometimes 25074ms and sometimes 24994ms (but delay is 25000ms) since starttime was calculated after reader creation