HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT #6424

PDavid · 2024-10-31T11:36:30Z

This is the backport of #6361 to branch-2.

stoty · 2024-11-04T05:18:42Z

The errors are unrelated.

Apache-HBase · 2024-11-05T10:00:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	8m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 25s		branch-2 passed
+1 💚	compile	5m 0s		branch-2 passed
+1 💚	checkstyle	1m 8s		branch-2 passed
+1 💚	spotbugs	2m 53s		branch-2 passed
+1 💚	spotless	0m 54s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 58s		the patch passed
+1 💚	compile	4m 30s		the patch passed
+1 💚	javac	4m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 19s		hbase-client: The patch generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5)
+1 💚	checkstyle	0m 45s		hbase-server: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	spotbugs	3m 12s		the patch passed
+1 💚	hadoopcheck	22m 51s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	0m 50s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 22s		The patch does not generate ASF License warnings.
		64m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6424
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux dc4cacb34fb1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a8cd79d`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-05T14:38:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 14s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 36s		branch-2 passed
+1 💚	compile	1m 52s		branch-2 passed
+1 💚	javadoc	1m 4s		branch-2 passed
+1 💚	shadedjars	7m 55s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 56s		the patch passed
+1 💚	compile	1m 46s		the patch passed
+1 💚	javac	1m 46s		the patch passed
+1 💚	javadoc	1m 8s		the patch passed
+1 💚	shadedjars	7m 38s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 7s		hbase-client in the patch passed.
+1 💚	unit	295m 6s		hbase-server in the patch passed.
		341m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6424
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux b3c1519c0fc2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a8cd79d`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/testReport/
Max. process+thread count	4345 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-05T14:40:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 58s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 16s		branch-2 passed
+1 💚	compile	2m 9s		branch-2 passed
+1 💚	javadoc	1m 17s		branch-2 passed
+1 💚	shadedjars	7m 35s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 6s		the patch passed
+1 💚	compile	2m 1s		the patch passed
+1 💚	javac	2m 1s		the patch passed
+1 💚	javadoc	1m 1s		the patch passed
+1 💚	shadedjars	7m 53s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	7m 45s		hbase-client in the patch passed.
-1 ❌	unit	285m 5s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		330m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6424
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 8cd71615e9ff 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a8cd79d`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/testReport/
Max. process+thread count	4141 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-05T18:35:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	16m 34s		Docker mode activated.
-0 ⚠️	yetus	0m 11s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	1m 50s		Maven dependency ordering for branch
+1 💚	mvninstall	5m 20s		branch-2 passed
+1 💚	compile	1m 15s		branch-2 passed
+1 💚	javadoc	1m 3s		branch-2 passed
+1 💚	shadedjars	6m 53s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 31s		the patch passed
+1 💚	compile	1m 9s		the patch passed
+1 💚	javac	1m 9s		the patch passed
+1 💚	javadoc	0m 48s		the patch passed
+1 💚	shadedjars	6m 40s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	8m 28s		hbase-client in the patch passed.
-1 ❌	unit	502m 43s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		577m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6424
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 578a53e217bb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a8cd79d`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/testReport/
Max. process+thread count	3968 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Co-authored-by: Dávid Paksy <[email protected]> Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit 0aee886)

PDavid mentioned this pull request Oct 31, 2024

HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT #6361

Merged

This comment has been minimized.

Sign in to view

PDavid marked this pull request as ready for review October 31, 2024 12:25

PDavid force-pushed the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch from 8060ca1 to f7f25c5 Compare October 31, 2024 13:38

This comment has been minimized.

Sign in to view

PDavid force-pushed the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch from f7f25c5 to 52a288d Compare October 31, 2024 15:48

This comment has been minimized.

Sign in to view

PDavid force-pushed the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch from 52a288d to ee84469 Compare November 4, 2024 09:59

This comment has been minimized.

Sign in to view

PDavid force-pushed the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch from ee84469 to 07047b6 Compare November 5, 2024 08:00

HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT

a8cd79d

PDavid force-pushed the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch from 07047b6 to a8cd79d Compare November 5, 2024 08:01

stoty merged commit 0aee886 into apache:branch-2 Nov 6, 2024
1 check failed

stoty pushed a commit that referenced this pull request Nov 6, 2024

HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT (#6424)

8c6247f

Co-authored-by: Dávid Paksy <[email protected]> Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit 0aee886)

stoty pushed a commit that referenced this pull request Nov 6, 2024

HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT (#6424)

815aa30

Co-authored-by: Dávid Paksy <[email protected]> Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit 0aee886)

PDavid deleted the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch November 6, 2024 09:57

HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT #6424

HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT #6424

Uh oh!

Conversation

PDavid commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

stoty commented Nov 4, 2024

Uh oh!

This comment has been minimized.

Apache-HBase commented Nov 5, 2024

Uh oh!

Apache-HBase commented Nov 5, 2024

Uh oh!

Apache-HBase commented Nov 5, 2024

Uh oh!

Apache-HBase commented Nov 5, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PDavid commented Oct 31, 2024 •

edited

Loading