Skip to content

HBASE-28627 REST ScannerModel doesn't support includeStartRow/include… #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

HBASE-28627 REST ScannerModel doesn't support includeStartRow/include… #6494

merged 1 commit into from
Feb 18, 2025

Conversation

@chandrasekhar-188k
Copy link
Contributor

@chandrasekhar-188k chandrasekhar-188k commented Nov 26, 2024

No description provided.

@chandrasekhar-188k chandrasekhar-188k mentioned this pull request Nov 26, 2024
Merged
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

Apache-HBase commented Jan 19, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 55s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 4s branch-2 passed
+1 💚 compile 0m 20s branch-2 passed
+1 💚 javadoc 0m 15s branch-2 passed
+1 💚 shadedjars 6m 6s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 1s the patch passed
+1 💚 compile 0m 20s the patch passed
+1 💚 javac 0m 20s the patch passed
+1 💚 javadoc 0m 14s the patch passed
+1 💚 shadedjars 6m 5s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 3m 34s hbase-rest in the patch passed.
25m 59s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6494
Optional Tests javac javadoc unit compile shadedjars
uname Linux a0316614e186 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 31848a3
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/testReport/
Max. process+thread count 1882 (vs. ulimit of 30000)
modules C: hbase-rest U: hbase-rest
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 19, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 23s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 36s branch-2 passed
+1 💚 compile 0m 32s branch-2 passed
+1 💚 javadoc 0m 21s branch-2 passed
+1 💚 shadedjars 5m 58s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 15s the patch passed
+1 💚 compile 0m 30s the patch passed
+1 💚 javac 0m 30s the patch passed
+1 💚 javadoc 0m 24s the patch passed
+1 💚 shadedjars 5m 55s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 4m 33s hbase-rest in the patch passed.
29m 38s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6494
Optional Tests javac javadoc unit compile shadedjars
uname Linux 2d1479538ea6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 31848a3
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/testReport/
Max. process+thread count 1795 (vs. ulimit of 30000)
modules C: hbase-rest U: hbase-rest
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 19, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 22s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 31s branch-2 passed
+1 💚 compile 0m 34s branch-2 passed
+1 💚 javadoc 0m 20s branch-2 passed
+1 💚 shadedjars 7m 4s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 59s the patch passed
+1 💚 compile 0m 25s the patch passed
+1 💚 javac 0m 25s the patch passed
+1 💚 javadoc 0m 18s the patch passed
+1 💚 shadedjars 7m 23s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 4m 17s hbase-rest in the patch passed.
32m 26s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6494
Optional Tests javac javadoc unit compile shadedjars
uname Linux 898517a057de 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 31848a3
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/testReport/
Max. process+thread count 1766 (vs. ulimit of 30000)
modules C: hbase-rest U: hbase-rest
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 19, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 buf 0m 0s buf was not available.
+0 🆗 buf 0m 0s buf was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 44s branch-2 passed
+1 💚 compile 0m 46s branch-2 passed
+1 💚 checkstyle 0m 16s branch-2 passed
+1 💚 spotbugs 0m 49s branch-2 passed
+1 💚 spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 10s the patch passed
+1 💚 compile 0m 38s the patch passed
+1 💚 cc 0m 38s the patch passed
+1 💚 javac 0m 39s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 13s /results-checkstyle-hbase-rest.txt hbase-rest: The patch generated 2 new + 23 unchanged - 0 fixed = 25 total (was 23)
+1 💚 spotbugs 0m 54s the patch passed
+1 💚 hadoopcheck 17m 31s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚 hbaseprotoc 0m 19s the patch passed
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
33m 15s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6494
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux 4b6d5f5b3492 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 31848a3
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-rest U: hbase-rest
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@chandrasekhar-188k
Copy link
Contributor Author

chandrasekhar-188k commented Feb 18, 2025

@stoty
pls help to review this PR.

@stoty
Copy link
Contributor

stoty commented Feb 18, 2025

This is the same as the master patch, but you've fixed it to apply it cleanly to branch-2 ?

Is that correct @chandrasekhar-188k ?

@stoty
Copy link
Contributor

stoty commented Feb 18, 2025

I can see this already includes HE_EQUALS_USE_HASHCODE.

stoty
stoty approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@stoty stoty merged commit e7b48e4 into apache:branch-2 Feb 18, 2025
1 check passed
stoty pushed a commit that referenced this pull request Feb 18, 2025
@chandrasekhar-188k @stoty
HBASE-28627 REST ScannerModel doesn't support includeStartRow/include…
e383a61 
…StopRow (#6494)

includes HBASE-29125 and JSON addendum

Signed-off-by: Istvan Toth <[email protected]>
(cherry picked from commit e7b48e4)
stoty pushed a commit that referenced this pull request Feb 18, 2025
@chandrasekhar-188k @stoty
HBASE-28627 REST ScannerModel doesn't support includeStartRow/include…
ea3c019 
…StopRow (#6494)

includes HBASE-29125 and JSON addendum

Signed-off-by: Istvan Toth <[email protected]>
(cherry picked from commit e7b48e4)
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
@chandrasekhar-188k @mokai87
HBASE-28627 REST ScannerModel doesn't support includeStartRow/include…
4ee2c8d 
…StopRow (apache#6494)

includes HBASE-29125 and JSON addendum

Signed-off-by: Istvan Toth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stoty stoty stoty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chandrasekhar-188k @Apache-HBase @stoty