[Tensorflow, NNVM, TOPI] Support for logical operators #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we expose these in Relay too? doesn't Numpy use different names for these operators? if so we should be consistent. |
|
@jroesch Names in numpy seem to be consistent with this commit. I am not much aware of the Relay side. Could you please send some quick pointers to start off? |
|
@ashutoshparkhi Here is a tutorial of adding an operator to Relay: https://docs.tvm.ai/dev/relay_add_op.html Hopefully this helps. |
|
@ashutoshparkhi can you please update on this PR? |
|
I'm up for doing the relay part in a follow-up PR if this is ok to merge for NNVM. |
|
OK, this is merged. @abergeron followup with relay op is more than welcomed |
tqchen
added
status: accepted
and removed
status: need update
|
Thank you @tqchen and @abergeron. |
bwasti
pushed a commit
to facebookexperimental/tvm
that referenced
this pull request
Mar 6, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
ghost
deleted the
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for logical OR/AND/NOT
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.