Skip to content

Conversation

@gemfield
Copy link
Contributor

@gemfield gemfield commented Apr 5, 2019

Enhance upsample operator to adapt onnx opset version 9 for nnvm compiler.

@gemfield
Copy link
Contributor Author

@srkreddy1238 @tqchen

@srkreddy1238
Copy link
Contributor

Implementation look ok.
Good to have a test case if possible.

@tqchen tqchen added the status: need test case need test cases to cover the change label Apr 16, 2019
@tqchen
Copy link
Member

tqchen commented Apr 20, 2019

ping @gemfield

@gemfield
Copy link
Contributor Author

@tqchen test cases added.
The new requested reviewers is triggered by mistake, just ignore it.

@tqchen
Copy link
Member

tqchen commented Apr 22, 2019

cc @srkreddy1238 please followup

Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gemfield . LGTM.

@srkreddy1238 srkreddy1238 merged commit 3f835bd into apache:master Apr 23, 2019
@srkreddy1238
Copy link
Contributor

Thanks @gemfield & @tqchen . This is now merged.

wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
apache#2968)

* Enhance upsample operator to adapt onnx opset version 9 for nnvm compiler

* Add upsample test case for newer opset in nnvm

* re-trigger the CI
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
apache#2968)

* Enhance upsample operator to adapt onnx opset version 9 for nnvm compiler

* Add upsample test case for newer opset in nnvm

* re-trigger the CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: need review status: need test case need test cases to cover the change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants