Skip to content

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Jun 7, 2019

Set of change I made when reading the pass infra code. Some of them should have been caught during code reviews.

Summary of code changes

  • It is wasteful to create a unordered_set every time and then check, just use a linear scan will have the same time complexity and should be fine if the set is small.
  • PassEnabled is not quite right(given that it uses GetPass to create a pass just to get the level)
  • Move dependency resolving into the sequential(which manages the passes).

Additional changes

  • Use PackedFunc for Pass lookup

cc @zhiics

Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for improvement.

@tqchen tqchen merged commit 4cee98b into apache:master Jun 7, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Jun 26, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Jun 27, 2019
@tqchen tqchen deleted the pass branch October 31, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants