[VTA] [Chisel] Added Chisel Module Unit Test Infrastructure #3698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmoreau89
reviewed
Aug 2, 2019
There was a problem hiding this comment.
Thank you @BenjaminTu for the good work. Can you link the closed PR in this conversation so that we have a record of the old review?
|
Also, please add a few sentences from the old PR in your new PR description, right now it is lacking context. |
|
Link to Old PR: #3682 |
BenjaminTu
changed the title
|
@liangfu please review! |
liangfu
approved these changes
Aug 3, 2019
tmoreau89
approved these changes
Aug 3, 2019
There was a problem hiding this comment.
Good work @BenjaminTu , looking forward to seeing this unit test infrastructure grow!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test infrastructure for testing chisel modules in isolation. (avoiding compiler and software support)
Provided sample test mvm, which tests for matrix vectors multiplication module in the gemm core