QNN quantize and dequantize operators. #3745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anijain2305
reviewed
Aug 9, 2019
anijain2305
reviewed
Aug 9, 2019
anijain2305
reviewed
Aug 12, 2019
anijain2305
reviewed
Aug 12, 2019
anijain2305
reviewed
Aug 12, 2019
anijain2305
reviewed
Aug 12, 2019
|
@u99127, @FrozenGene, @jackwish, @tqchen can you take a look at this PR. |
Hi @shoubhik I have a little busy today. I could have time to look tomorrow. Thanks. |
zhenhuaw-me
approved these changes
Aug 13, 2019
leo-blonk
approved these changes
Aug 13, 2019
|
Resolved all the style related comments. |
FrozenGene
approved these changes
Aug 14, 2019
|
@tqchen Can you please review and merge this, given we have approvals from all the stakeholders. |
|
Sorry I will be traveling in the incoming weeks, perhaps @ZihengJiang @vinx13 can help manage QNN related PRs |
|
@ZihengJiang @vinx13 can you review and merge this PR. |
vinx13
approved these changes
Aug 14, 2019
|
@shoubhik Please resolve the conflict (I have merged the other PR) |
# Conflicts: # python/tvm/relay/qnn/op/qnn.py
|
There is a dependency on #3779. Once it is merged the test case can pass. |
|
@vinx13 Can this be merged now? |
vinx13
reviewed
Aug 16, 2019
|
@vinx13 can it be merged now? |
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Aug 16, 2019
* QNN quantize and dequantize operators. * addressing review comments. * addressing review comments. * Adding new line at the end of the file. * Adhering to styling guidelines. * Adding name to contributors. * Fixing lint issue. * Fixing file name. * Removing unnecessary code.
anijain2305
pushed a commit
to anijain2305/tvm
that referenced
this pull request
Aug 22, 2019
* QNN quantize and dequantize operators. * addressing review comments. * addressing review comments. * Adding new line at the end of the file. * Adhering to styling guidelines. * Adding name to contributors. * Fixing lint issue. * Fixing file name. * Removing unnecessary code.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
* QNN quantize and dequantize operators. * addressing review comments. * addressing review comments. * Adding new line at the end of the file. * Adhering to styling guidelines. * Adding name to contributors. * Fixing lint issue. * Fixing file name. * Removing unnecessary code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR for #3531. It has the implementations for the Quantize and Dequantize operators.