[Relay][Frontend][TFLite] Implementation of tile for TFLite #3814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kevinthesun @icemelon9 I would appreciate if you can help to manage it, thanks :) |
|
@apivovarov Could you help review since you worked on TFLite as well? |
FrozenGene
approved these changes
Aug 22, 2019
anijain2305
reviewed
Aug 23, 2019
| # reps (tuple of int) – The number of times repeating the tensor data. | ||
| reps = tuple(self.get_tensor_value(input_tensors[1])) | ||
|
|
||
| out = _op.tile(in_expr, reps) |
There was a problem hiding this comment.
Minor comment - Maybe directly return _op.tile(...)
There was a problem hiding this comment.
Maybe current implementation is acceptable. Because all other ops are implemented in this way:
out = _op.xx()
# if there are fused activation fn:
# out = self.convert_fused_activation_function(out, fused_activation_fn)
return out
There was a problem hiding this comment.
Yes, this is far from a blocking comment :) Consistency is better
anijain2305
approved these changes
Aug 23, 2019
|
Hi @hlu1 I would appreciate if you can help to manage it, thanks :) |
jroesch
approved these changes
Sep 1, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @FrozenGene
I add the missing operator 'tile' for TFLite, I would appreciate if you can help to review it, thanks.