Skip to content

Conversation

@inadob
Copy link
Contributor

@inadob inadob commented Oct 10, 2019

This implementation provides cast to limited number of dtypes that tflite
currently supports for placeholder op. The encoding values for
placeholder dtypes are taken from the tflite flatbuff schema.

@tqchen
Copy link
Member

tqchen commented Oct 10, 2019

Thanks for contributing, please request reviews from reviewers

@inadob
Copy link
Contributor Author

inadob commented Oct 11, 2019

@FrozenGene @kevinthesun can you please take a look at this patch

This implementation provides cast to limited number of dtypes
that tflite currently supports for placeholder op. Add INT64 in the
possible dtypes as it appears to be supported accrording to tlfite schema.
@inadob
Copy link
Contributor Author

inadob commented Oct 11, 2019

@FrozenGene as you suggested the dtype enumeration dictionary is now removed and instead I use get_tensor_type_str

Copy link
Member

@FrozenGene FrozenGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tqchen tqchen merged commit 068c148 into apache:master Oct 13, 2019
@tqchen
Copy link
Member

tqchen commented Oct 13, 2019

Thanks @FrozenGene @inadob

anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Oct 17, 2019
This implementation provides cast to limited number of dtypes
that tflite currently supports for placeholder op. Add INT64 in the
possible dtypes as it appears to be supported accrording to tlfite schema.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 18, 2019
This implementation provides cast to limited number of dtypes
that tflite currently supports for placeholder op. Add INT64 in the
possible dtypes as it appears to be supported accrording to tlfite schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants