[TF][Relay][Op] Pass module when infer shape #4287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongwww
reviewed
Nov 9, 2019
icemelon
requested changes
Nov 9, 2019
soiferj
approved these changes
Nov 9, 2019
wweic
force-pushed
the
pass-module-shape-infer
branch
from
9488d71 to
6751030
Compare
|
Seems like the error is unrelated to my change: #4284 |
wweic
force-pushed
the
pass-module-shape-infer
branch
from
6751030 to
03f5174
Compare
|
@icemelon9 could you take another look? |
icemelon
approved these changes
Nov 11, 2019
|
Thanks @wweic |
zxy844288792
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Nov 13, 2019
* [TF][Relay][Op] Pass module when infer shape * Fix lint * Improve style * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing tests should be sufficient to validate this change. It's not easy to craft a unit test case that failed before and pass after this change.
Discussion: https://discuss.tvm.ai/t/tensorarray-globalvar-and-globaltypevar-confusion/4567/17
cc @yongwww @zhiics @icemelon9 @kevinthesun @srkreddy1238