-
Notifications
You must be signed in to change notification settings - Fork 971
[K8S][HELM] Add configuration files support to helm chart #4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm not sure about default values for
|
Codecov Report
@@ Coverage Diff @@
## master #4004 +/- ##
============================================
- Coverage 52.11% 52.08% -0.03%
Complexity 13 13
============================================
Files 541 541
Lines 29468 29468
Branches 3938 3938
============================================
- Hits 15357 15349 -8
- Misses 12709 12712 +3
- Partials 1402 1407 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @dnskr
You can find it in the master branch doc(unreleased), the latest doc represents the latest stable release doc.
Sorry for confusing, I opened #4005 to explain and fix it. |
|
@hddong @dnskr some thoughts about the schema of How about change For "bind" part, the port is not sufficient since Kyuubi supports multi protocols, not only thrift binary now. |
Agree with both suggestions. I left it as is just because I'm quite new in Kyuubi and don't fully understand all moving pieces. But I have enthusiasm to continue exploring it and creating PRs. |
|
Merged to master, thanks @dnskr for your contribution and passion. The team is suffering from COVID-19, and may not be able to reply in time. |
|
@dnskr Hi, #3982 is closed, while I am afraid that it won't help in your case since it was refactored to refresh users' default configs only as dissucssed in PR 3983. But you can still consider follow the similar pattern to achieve it as the following as 3982 does,
|
Why are the changes needed?
The changes allow to:
kyuubi-env.shkyuubi-defaults.conflog4j2.xmlHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request