[KYUUBI #4617] [AUTHZ] Collect results for filtered show objects ahead to prevent holding unserializable spark plan #4634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenliang123
changed the title
bowenliang123
changed the title
bowenliang123
requested review from
yaooqinn and
zhaomin1423
and removed request for
yaooqinn and
zhaomin1423
Codecov Report
@@ Coverage Diff @@
## master #4634 +/- ##
============================================
- Coverage 57.62% 53.58% -4.04%
Complexity 13 13
============================================
Files 579 579
Lines 31901 31812 -89
Branches 4263 4253 -10
============================================
- Hits 18383 17048 -1335
- Misses 11759 13175 +1416
+ Partials 1759 1589 -170
... and 48 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bowenliang123
force-pushed
the
4617-filter
branch
from
24a668e to
65ce03a
Compare
bowenliang123
added a commit
that referenced
this pull request
Mar 31, 2023
…d to prevent holding unserializable spark plan ### _Why are the changes needed?_ To fix #4617. - The reason for issue #4617 is that delegated SparkPlan is not serilizable when execution - Collect results for filtered show objects ahead in FilterDataSourceV2Strategy to prevent holding the delegated plan ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4634 from bowenliang123/4617-filter. Closes #4617 fe00ef5 [liangbowen] rename results to result 65ce03a [liangbowen] fix 4617 Authored-by: liangbowen <[email protected]> Signed-off-by: liangbowen <[email protected]> (cherry picked from commit 92f191a) Signed-off-by: liangbowen <[email protected]>
|
Thanks, merged to master/1.7.1 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To fix #4617.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request