fix review comments

Author: iRakson

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala

@@ -247,7 +247,7 @@ abstract class HashExpression[E] extends Expression {
 
   override def nullable: Boolean = false
 
-  protected def hasMapType(dt: DataType): Boolean = {
+  private def hasMapType(dt: DataType): Boolean = {
     dt.existsRecursively(_.isInstanceOf[MapType])
   }
 
@@ -259,8 +259,8 @@ abstract class HashExpression[E] extends Expression {
       !SQLConf.get.getConf(SQLConf.LEGACY_USE_HASH_ON_MAPTYPE)) {
       TypeCheckResult.TypeCheckFailure(
         s"input to function $prettyName cannot contain elements of MapType. Logically same maps " +
-          s"may have different hashcode, thus hash expressions are prohibited on MapType " +
-          s"elements. To restore previous behavior set spark.sql.legacy.useHashOnMapType to true.")
+          "may have different hashcode, thus hash expressions are prohibited on MapType " +
+          "elements. To restore previous behavior set spark.sql.legacy.useHashOnMapType to true.")
     } else {
       TypeCheckResult.TypeCheckSuccess
     }

sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala

@@ -2208,8 +2208,8 @@ object SQLConf {
   val LEGACY_USE_HASH_ON_MAPTYPE = buildConf("spark.sql.legacy.useHashOnMapType")
     .doc("When set to true, hash expressions can be applied on elements of MapType. Otherwise, " +
       "an analysis exception will be thrown.")
-    .booleanConf.
-    createWithDefault(false)
+    .booleanConf
+    .createWithDefault(false)
 
   /**
    * Holds information about keys that have been deprecated.

sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

@@ -2134,12 +2134,11 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
       case hashExpression =>
         withSQLConf(SQLConf.LEGACY_USE_HASH_ON_MAPTYPE.key -> true.toString()) {
           val df = spark.createDataset(Map() :: Nil)
-          checkAnswer(df.selectExpr("hash(*)"), sql("SELECT hash(map())"))
+          checkAnswer(df.selectExpr(s"$hashExpression(*)"), sql(s"SELECT $hashExpression(map())"))
         }
     }
   }
 
-
   test("xxhash64 function") {
     val df = Seq(1 -> "a", 2 -> "b").toDF("i", "j")
     withTempView("tbl") {