Skip to content

Commit 0ee67a2

Browse files
author
Andrew Or
committed
Minor wording suggestions
1 parent 1c66046 commit 0ee67a2

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

network/shuffle/src/main/java/org/apache/spark/network/sasl/ShuffleSecretManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class ShuffleSecretManager implements SecretKeyHolder {
3737
private static final Charset UTF8_CHARSET = Charset.forName("UTF-8");
3838

3939
// Spark user used for authenticating SASL connections
40-
// Note that this should match the value in org.apache.spark.SecurityManager
40+
// Note that this must match the value in org.apache.spark.SecurityManager
4141
private static final String SPARK_SASL_USER = "sparkSaslUser";
4242

4343
/**

yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,9 @@ class ExecutorRunnable(
9191

9292
ctx.setApplicationACLs(YarnSparkHadoopUtil.getApplicationAclsForYarn(securityMgr))
9393

94-
// If external shuffle service is enabled, register with the
95-
// Yarn shuffle service already started on the node manager
94+
// If external shuffle service is enabled, register with the Yarn shuffle service already
95+
// started on the NodeManager and, if authentication is enabled, provide it with our secret
96+
// key for fetching shuffle files later
9697
if (sparkConf.getBoolean("spark.shuffle.service.enabled", false)) {
9798
val secretString = securityMgr.getSecretKey()
9899
val secretBytes =

yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,9 @@ class ExecutorRunnable(
9090

9191
ctx.setApplicationACLs(YarnSparkHadoopUtil.getApplicationAclsForYarn(securityMgr))
9292

93-
// If external shuffle service is enabled, register with the
94-
// Yarn shuffle service already started on the node manager
93+
// If external shuffle service is enabled, register with the Yarn shuffle service already
94+
// started on the NodeManager and, if authentication is enabled, provide it with our secret
95+
// key for fetching shuffle files later
9596
if (sparkConf.getBoolean("spark.shuffle.service.enabled", false)) {
9697
val secretString = securityMgr.getSecretKey()
9798
val secretBytes =

0 commit comments

Comments
 (0)