Skip to content

Commit 3d985a4

Browse files
committed
address comments
1 parent d47687f commit 3d985a4

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,7 @@ private[sql] object PythonSQLUtils {
4444
val conf = new SQLConf()
4545
// Force to build static SQL configurations
4646
StaticSQLConf
47-
// set nondeterministic configurations with general meanings
48-
conf.getAllDefinedConfs.map {
49-
case p @ (SQLConf.SESSION_LOCAL_TIMEZONE.key, _, _, _) =>
50-
p.copy(_2 = "value of local timezone")
51-
case p @ (StaticSQLConf.WAREHOUSE_PATH.key, _, _, _) =>
52-
p.copy(_2 = "value of $PWD/spark-warehouse")
53-
case o => o
54-
}
47+
conf.getAllDefinedConfs
5548
}
5649

5750
def listRuntimeSQLConfigs(): Array[(String, String, String, String)] = {

sql/gen-sql-config-docs.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,11 @@ def generate_sql_configs_table_html(sql_configs, path):
8181
"""
8282
))
8383
for config in sorted(sql_configs, key=lambda x: x.name):
84-
if config.default == "<undefined>":
84+
if config.name =="spark.sql.session.timeZone":
85+
default = "(value of local timezone)"
86+
elif config.name == "spark.sql.warehouse.dir":
87+
default = "(value of <code>$PWD/spark-warehouse</code>)"
88+
elif config.default == "<undefined>":
8589
default = "(none)"
8690
elif config.default.startswith("<value of "):
8791
referenced_config_name = value_reference_pattern.match(config.default).group(1)

0 commit comments

Comments
 (0)