SPARK-11246 implement code review comment

xwu0226 · xwu0226 · commit 3f25d6a1b330 · 2015-10-28T22:17:00.000-07:00
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
@@ -17,7 +17,6 @@
 
 package org.apache.spark.sql.catalyst.plans.logical
 
-import org.apache.spark.sql.catalyst.analysis.EliminateSubQueries
 import org.apache.spark.sql.catalyst.encoders._
 import org.apache.spark.sql.catalyst.expressions._
 import org.apache.spark.sql.catalyst.expressions.aggregate.Utils
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala
@@ -62,6 +62,9 @@ case class LogicalRelation(
     case _ => false
   }
 
+  // When comparing two LogicalRelations from within LogicalPlan.sameResult, we only need
+  // LogicalRelation.cleanArgs to return Seq(relation), since expectedOutputAttribute's expId can be different
+  // but the relation is still the same.
   override lazy val cleanArgs: Seq[Any] = Seq(relation)
 
   @transient override lazy val statistics: Statistics = Statistics(

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,9 @@ case class LogicalRelation(`
`62`	`62`	`case _ => false`
`63`	`63`	`}`
`64`	`64`
	`65`	`+ // When comparing two LogicalRelations from within LogicalPlan.sameResult, we only need`
	`66`	`+ // LogicalRelation.cleanArgs to return Seq(relation), since expectedOutputAttribute's expId can be different`
	`67`	`+ // but the relation is still the same.`
`65`	`68`	`override lazy val cleanArgs: Seq[Any] = Seq(relation)`
`66`	`69`
`67`	`70`	`@transient override lazy val statistics: Statistics = Statistics(`