Skip to content

Commit 4a66e90

Browse files
committed
added some comments for test additions
1 parent a22a2cc commit 4a66e90

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

python/pyspark/ml/tests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,7 @@ def check_params(test_self, py_stage, check_params_exist=True):
411411
- set of params exist in Java and Python and are ordered by names
412412
- param parent has the same UID as the object's UID
413413
- default param value from Java matches value in Python
414+
- optionally check if all params from Java also exist in Python
414415
"""
415416
py_stage_str = "%s %s" % (type(py_stage), py_stage)
416417
if not hasattr(py_stage, "_to_java"):
@@ -1370,6 +1371,7 @@ def test_java_params(self):
13701371
for name, cls in inspect.getmembers(module, inspect.isclass):
13711372
if not name.endswith('Model') and issubclass(cls, JavaParams)\
13721373
and not inspect.isabstract(cls):
1374+
# NOTE: disable check_params_exist until there is parity with Scala API
13731375
ParamTests.check_params(self, cls(), check_params_exist=False)
13741376

13751377

0 commit comments

Comments
 (0)