Skip to content

Commit 750a632

Browse files
committed
Fix
1 parent 17ce605 commit 750a632

File tree

3 files changed

+517
-2
lines changed

3 files changed

+517
-2
lines changed

sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,17 @@ class TPCDSQuerySuite extends BenchmarkQueryTest with TPCDSSchema {
4646
"q81", "q82", "q83", "q84", "q85", "q86", "q87", "q88", "q89", "q90",
4747
"q91", "q92", "q93", "q94", "q95", "q96", "q97", "q98", "q99")
4848

49+
val sqlConfgs = Seq(
50+
SQLConf.CBO_ENABLED.key -> "true",
51+
SQLConf.PLAN_STATS_ENABLED.key -> "true",
52+
SQLConf.JOIN_REORDER_ENABLED.key -> "true"
53+
)
54+
4955
tpcdsQueries.foreach { name =>
5056
val queryString = resourceToString(s"tpcds/$name.sql",
5157
classLoader = Thread.currentThread().getContextClassLoader)
5258
test(name) {
53-
withSQLConf(SQLConf.CROSS_JOINS_ENABLED.key -> "true") {
59+
withSQLConf(sqlConfgs: _*) {
5460
// check the plans can be properly generated
5561
val plan = sql(queryString).queryExecution.executedPlan
5662
checkGeneratedCode(plan)
@@ -69,7 +75,7 @@ class TPCDSQuerySuite extends BenchmarkQueryTest with TPCDSSchema {
6975
val queryString = resourceToString(s"tpcds-v2.7.0/$name.sql",
7076
classLoader = Thread.currentThread().getContextClassLoader)
7177
test(s"$name-v2.7") {
72-
withSQLConf(SQLConf.CROSS_JOINS_ENABLED.key -> "true") {
78+
withSQLConf(sqlConfgs: _*) {
7379
// check the plans can be properly generated
7480
val plan = sql(queryString).queryExecution.executedPlan
7581
checkGeneratedCode(plan)

sql/core/src/test/scala/org/apache/spark/sql/TPCDSSchema.scala

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717

1818
package org.apache.spark.sql
1919

20+
import org.apache.spark.sql.catalyst.TableIdentifier
21+
2022
trait TPCDSSchema {
2123

2224
private val tableColumns = Map(
@@ -255,5 +257,9 @@ trait TPCDSSchema {
255257
|USING $format
256258
|${options.mkString("\n")}
257259
""".stripMargin)
260+
261+
// To simulate plan generation on actual TPCDS data, injects data stats here
262+
spark.sessionState.catalog.alterTableStats(
263+
TableIdentifier(tableName), Some(TPCDSTableStats.sf100TableStats(tableName)))
258264
}
259265
}

0 commit comments

Comments
 (0)