Small fixes based on code review.

Author: jkbradley

mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala

@@ -348,8 +348,7 @@ class DistributedLDAModel private (
 
   /** Java-friendly version of [[topicDistributions]] */
   def javaTopicDistributions: JavaPairRDD[java.lang.Long, Vector] = {
-    new JavaPairRDD[java.lang.Long, Vector](
-      topicDistributions.asInstanceOf[RDD[(java.lang.Long, Vector)]])
+    JavaPairRDD.fromRDD(topicDistributions.asInstanceOf[RDD[(java.lang.Long, Vector)]])
   }
 
   // TODO:

mllib/src/main/scala/org/apache/spark/mllib/stat/Statistics.scala

@@ -101,6 +101,7 @@ object Statistics {
    */
   def corr(x: RDD[Double], y: RDD[Double], method: String): Double = Correlations.corr(x, y, method)
 
+  /** Java-friendly version of [[corr()]] */
   def corr(x: JavaRDD[java.lang.Double], y: JavaRDD[java.lang.Double], method: String): Double =
     corr(x.rdd.asInstanceOf[RDD[Double]], y.rdd.asInstanceOf[RDD[Double]], method)
 

mllib/src/test/java/org/apache/spark/ml/param/JavaParamsSuite.java

@@ -50,7 +50,7 @@ public void testParams() {
     testParams.setMyIntParam(2).setMyDoubleParam(0.4).setMyStringParam("a");
     Assert.assertEquals(testParams.getMyDoubleParam(), 0.4, 0.0);
     Assert.assertEquals(testParams.getMyStringParam(), "a");
-    Assert.assertArrayEquals(testParams.getMyDoubleArrayParam(), new double[]{1.0, 2.0}, 0.0);
+    Assert.assertArrayEquals(testParams.getMyDoubleArrayParam(), new double[] {1.0, 2.0}, 0.0);
   }
 
   @Test

mllib/src/test/java/org/apache/spark/ml/param/JavaTestParams.java

@@ -51,7 +51,8 @@ public String uid() {
   public int getMyIntParam() { return (Integer)getOrDefault(myIntParam_); }
 
   public JavaTestParams setMyIntParam(int value) {
-    set(myIntParam_, value); return this;
+    set(myIntParam_, value);
+    return this;
   }
 
   private DoubleParam myDoubleParam_;
@@ -60,7 +61,8 @@ public JavaTestParams setMyIntParam(int value) {
   public double getMyDoubleParam() { return (Double)getOrDefault(myDoubleParam_); }
 
   public JavaTestParams setMyDoubleParam(double value) {
-    set(myDoubleParam_, value); return this;
+    set(myDoubleParam_, value);
+    return this;
   }
 
   private Param<String> myStringParam_;
@@ -69,7 +71,8 @@ public JavaTestParams setMyDoubleParam(double value) {
   public String getMyStringParam() { return getOrDefault(myStringParam_); }
 
   public JavaTestParams setMyStringParam(String value) {
-    set(myStringParam_, value); return this;
+    set(myStringParam_, value);
+    return this;
   }
 
   private DoubleArrayParam myDoubleArrayParam_;
@@ -78,12 +81,12 @@ public JavaTestParams setMyStringParam(String value) {
   public double[] getMyDoubleArrayParam() { return getOrDefault(myDoubleArrayParam_); }
 
   public JavaTestParams setMyDoubleArrayParam(double[] value) {
-    set(myDoubleArrayParam_, value); return this;
+    set(myDoubleArrayParam_, value);
+    return this;
   }
 
   private void init() {
-    myIntParam_ = new IntParam(this, "myIntParam", "this is an int param",
-      ParamValidators.gt(0));
+    myIntParam_ = new IntParam(this, "myIntParam", "this is an int param", ParamValidators.gt(0));
     myDoubleParam_ = new DoubleParam(this, "myDoubleParam", "this is a double param",
       ParamValidators.inRange(0.0, 1.0));
     List<String> validStrings = Lists.newArrayList("a", "b");
@@ -92,11 +95,11 @@ private void init() {
     myDoubleArrayParam_ =
       new DoubleArrayParam(this, "myDoubleArrayParam", "this is a double param");
 
-    setDefault(myIntParam_, 1);
-    setDefault(myIntParam_.w(1));
-    setDefault(myDoubleParam_, 0.5);
+    setDefault(myIntParam(), 1);
+    setDefault(myIntParam().w(1));
+    setDefault(myDoubleParam(), 0.5);
     setDefault(myIntParam().w(1), myDoubleParam().w(0.5));
-    setDefault(myDoubleArrayParam_, new double[]{1.0, 2.0});
-    setDefault(myDoubleArrayParam_.w(new double[]{1.0, 2.0}));
+    setDefault(myDoubleArrayParam(), new double[] {1.0, 2.0});
+    setDefault(myDoubleArrayParam().w(new double[] {1.0, 2.0}));
   }
 }

mllib/src/test/java/org/apache/spark/mllib/stat/JavaStatisticsSuite.java

@@ -44,7 +44,7 @@ public void tearDown() {
   }
 
   @Test
-  public void runStatisticsUsingStaticMethods() {
+  public void testCorr() {
     JavaRDD<Double> x = sc.parallelize(Lists.newArrayList(1.0, 2.0, 3.0, 4.0));
     JavaRDD<Double> y = sc.parallelize(Lists.newArrayList(1.1, 2.2, 3.1, 4.3));