[SPARK-28330][SQL][FOLLOWUP] Move the check of Offset from analysis to finsh analysis #36319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @dtenedor cc @cloud-fan |
dtenedor
approved these changes
Apr 22, 2022
cloud-fan
reviewed
Apr 25, 2022
| plan.foreachUp { | ||
| case o if !o.isInstanceOf[GlobalLimit] && !o.isInstanceOf[LocalLimit] | ||
| && o.children.exists(_.isInstanceOf[Offset]) => | ||
| throw new IllegalStateException( |
Contributor
There was a problem hiding this comment.
This is a user-facing error, we should use AnalysisException
cloud-fan
reviewed
Apr 25, 2022
| } | ||
|
|
||
| /** | ||
| * Validate whether the [[Offset]] is valid. |
Contributor
There was a problem hiding this comment.
Let's explain the reason. Dataset API eagerly analyzes the query, so a query plan may contain invalid Offset operators but it's not the final query plan that gets evaluated.
Contributor
Author
|
Because #36417 merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#35975 supported ANSI SQL: result offset clause.
We make some check for offset in
CheckAnalysis.The behavior prevents add offset API into
Dataset.So this PR move the check of Offset from analysis to finsh analysis.
Why are the changes needed?
Let we can add offset API into
Dataset.Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
New tests