[SPARK-38897][SQL] DS V2 supports push down string functions #36330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please add databases supports these functions into description. |
beliefer
reviewed
Apr 24, 2022
...talyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 24, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 24, 2022
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 24, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 25, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 25, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 25, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 25, 2022
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 25, 2022
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 25, 2022
Contributor
beliefer
left a comment
beliefer
left a comment
There was a problem hiding this comment.
Please investigate the syntax of trim carefully.
HyukjinKwon
changed the title
beliefer
reviewed
Apr 25, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java
Outdated
Show resolved
Hide resolved
beliefer
approved these changes
Apr 25, 2022
Contributor
beliefer
left a comment
beliefer
left a comment
There was a problem hiding this comment.
LGTM except one comment.
beliefer
reviewed
Apr 25, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 25, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 25, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 25, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 25, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Apr 25, 2022
...talyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Apr 25, 2022
...talyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 26, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 26, 2022
...talyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 26, 2022
...talyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Apr 26, 2022
...talyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Apr 27, 2022
...talyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Apr 27, 2022
...talyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java
Outdated
Show resolved
Hide resolved
beliefer
reviewed
May 18, 2022
Contributor
cloud-fan
reviewed
May 18, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 18, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 18, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 18, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Show resolved
Hide resolved
cloud-fan
reviewed
May 18, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 18, 2022
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 18, 2022
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 18, 2022
beliefer
reviewed
May 19, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Outdated
Show resolved
Hide resolved
| " FOR " + inputs(3) + ")"; | ||
| } else { | ||
| throw new IllegalStateException("Unexpected V2 function: OVERLAY"); | ||
| } |
Contributor
There was a problem hiding this comment.
if (inputs.length == 3) {
"OVERLAY(" + inputs(0) + " PLACING " + inputs(1) + " FROM " + inputs(2) + ")";
} else {
"OVERLAY(" + inputs(0) + " PLACING " + inputs(1) + " FROM " + inputs(2) +
" FOR " + inputs(3) + ")";
}
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
Show resolved
Hide resolved
cloud-fan
approved these changes
May 23, 2022
Contributor
|
thanks, merging to master! |
Contributor
Author
|
@cloud-fan @huaxingao @beliefer Thank you a lot! |
|
@cloud-fan Hello, may I ask how to push down the above functions in MySQL protocol? After studying this PR, does it solve the problem of deriving the str function from H2DB? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, Spark have some string functions of ANSI standard. Please refer
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
Line 503 in 2f8613f
These functions show below:
SUBSTRING,UPPER,LOWER,TRANSLATE,TRIM,OVERLAYThe mainstream databases support these functions show below.
SUBSTRINGUPPERLOWERTRIMTRANSLATEOVERLAYDS V2 should supports push down these string functions.
Why are the changes needed?
DS V2 supports push down string functions
Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
New tests.