[skip ci][ci] Fix broken test skips #11456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
commented
May 25, 2022
|
|
||
| if str(arg_type).startswith("typing.List"): | ||
| kwargs["nargs"] = "+" | ||
| kwargs["action"] = "append" |
Member
Author
There was a problem hiding this comment.
this was broken before, only the latest test was added to the args list, this fixes it so the snippet in the PR body works correctly
areusch
approved these changes
May 25, 2022
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually tested locally this time via, both tests are successfully skipped
python tests/scripts/ci.py gpu \ --tests tests/python/frontend/paddlepaddle/test_forward.py::test_forward_group_norm \ --tests tests/python/unittest/test_auto_scheduler_evolutionary_search.py::test_mutate_parallelcc @Mousius @areusch