[MetaSchedule] Allow MultiLevelTilingTensorCore rule to specify multiple tensor intrin groups #12113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple tensor intrin groups
masahi
reviewed
Jul 16, 2022
| tensor_intrin.get_wmma_intrin_group(write_reuse_scope, _in_dtype, _out_dtype, _trans_b) | ||
| for _in_dtype in in_dtype | ||
| for _out_dtype in out_dtype | ||
| for _trans_b in trans_b |
Member
There was a problem hiding this comment.
Given a compute, isn't there only one group that's valid?
Member
Author
There was a problem hiding this comment.
yes, this is to allow one single rule to apply to different workloads (different dtypes).
masahi
approved these changes
Jul 16, 2022
Member
masahi
left a comment
masahi
left a comment
There was a problem hiding this comment.
I'd say it should be the responsibility of a user to select the right dtype etc for a given workload, but I can imagine that this is useful for tuning e2e models having different kinds of workload with a single rule.
62 tasks
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…ple tensor intrin groups (apache#12113)
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
…ple tensor intrin groups (apache#12113)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR made it possible to specify multiple tensor core intrinsics (for different dtype) at the same time.
cc @masahi @spectrometerHBH @junrushao1994