[Meta Schedule][XGBoost] Update the custom callback function of xgboost in meta schedule #12141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxybazh
reviewed
Jul 25, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Generally it looks good, some more unit tests are required, and a few nit picks. I would also expect some integration test locally with the tune_relay functions to make sure the tuning works fine with migrated cost model.
shingjan
force-pushed
the
meta_schedule_xgboost_callback
branch
from
2fda92d to
2f42667
Compare
shingjan
force-pushed
the
meta_schedule_xgboost_callback
branch
from
2f42667 to
2c80287
Compare
shingjan
commented
Jul 27, 2022
zxybazh
reviewed
Jul 27, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
Thanks for the changes and feedbacks. The test looks ok to me and I will be fine with it as long as we can pass the CI. Let's finish the PR and get it in once the local integration tests are done!
shingjan
force-pushed
the
meta_schedule_xgboost_callback
branch
from
be956d7 to
9444134
Compare
zxybazh
reviewed
Jul 27, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
Just one nit, otherwise LGTM. Would you please also run some local integration tests and let me know the results?
Author
|
Local integration test for resnet18/llvm: Profiler table: |
Author
|
@tvm-bot rerun |
Author
|
bert base llvm: profiler table |
Author
|
bert base cuda: profiler table: |
Author
|
resnet18 cuda: profiler table: |
Author
|
mobilenetv2 on cuda profiler table |
Author
|
bert base on llvm 20k trials: profiler table |
shingjan
force-pushed
the
meta_schedule_xgboost_callback
branch
from
087ed69 to
918ea89
Compare
zxybazh
force-pushed
the
meta_schedule_xgboost_callback
branch
from
918ea89 to
33eb891
Compare
Author
|
@zxybazh The pandas warning should be suppressed now with the last commit. |
zxybazh
force-pushed
the
meta_schedule_xgboost_callback
branch
from
46507b3 to
33eb891
Compare
junrushao
reviewed
Sep 23, 2022
junrushao
reviewed
Sep 23, 2022
shingjan
force-pushed
the
meta_schedule_xgboost_callback
branch
from
33eb891 to
08663ae
Compare
zxybazh
approved these changes
Sep 23, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
Thanks @shingjan for the hard work and @junrushao for reviewing!
Member
|
@tvm-bot rerun |
junrushao
pushed a commit
that referenced
this pull request
Sep 30, 2022
Previous upgrade introduced a import of xgboost in meta_schedule, removed in current version by using a function to return the call back class. We've recently introduced a XGBoost Model upgrade to support new xgboost version of callback class in #12141. However, in this PR it uses a function called `optional_xgboost_callback` that works to avoid compatibility issue (xgboost 1.5.2 v.s. 1.6.0). In this specific function, it tries to import the newly introduced xgboost callback class and create a new class using it as base class. This actually imported xgboost when meta_schedule is imported, which is not ideal because xgboost is not a dependency of tvm and meta_schedule, it should only be required when xgboost cost model is employed. This PR fixes the problem by moving the class and the function mentioned above under a function that returns this class when needed. In this way we avoided unwanted import of xgboost in meta_schedule.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…st in meta schedule (apache#12141) * update the custom callback function of xgboost * fix lint * fix ci * fix lint * add unit test * remote unused code * fix lint * add decorator * address comment * fix lint * address comments * fix mypy * fix lint * remove unused comments * address comments * Fix xgboost unit test import. Co-authored-by: Xiyou Zhou <[email protected]>
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Previous upgrade introduced a import of xgboost in meta_schedule, removed in current version by using a function to return the call back class. We've recently introduced a XGBoost Model upgrade to support new xgboost version of callback class in apache#12141. However, in this PR it uses a function called `optional_xgboost_callback` that works to avoid compatibility issue (xgboost 1.5.2 v.s. 1.6.0). In this specific function, it tries to import the newly introduced xgboost callback class and create a new class using it as base class. This actually imported xgboost when meta_schedule is imported, which is not ideal because xgboost is not a dependency of tvm and meta_schedule, it should only be required when xgboost cost model is employed. This PR fixes the problem by moving the class and the function mentioned above under a function that returns this class when needed. In this way we avoided unwanted import of xgboost in meta_schedule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to update the custom callback function of xgboost in meta schedule.
This change is tested against xgboost==(1.2.0, 1.5.2 & 1.6.0) to ensure backwards compatibility on
tests/python/unittest/test_meta_schedule_cost_model.py.This is related to the second action item in #12009.
cc: @zxybazh @junrushao1994