Skip to content

Conversation

@balaram-cadence
Copy link
Contributor

@balaram-cadence balaram-cadence commented Jan 31, 2023

Fixes #13855
cc: @yongwww

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 31, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: frontend, tensorflow See #10317 for details

Generated by tvm-bot

Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yongwww
Copy link
Member

yongwww commented Feb 3, 2023

@balaram-cadence CI failed due to "[2] trailing_period: FAILED: PR must not end in a tailing '.'", could you please remove the tailing .?

@balaram-cadence
Copy link
Contributor Author

Thanks for the review, @yongwww I'll fix this.

@balaram-cadence balaram-cadence force-pushed the cadence/balaram/selectv2_bugfix branch from dafcf32 to 706dc31 Compare February 3, 2023 18:41
@balaram-cadence balaram-cadence changed the title [Frontend][Tensorflow] Update Select to SelectV2. [Frontend][Tensorflow] Update Select to SelectV2 Feb 3, 2023
@balaram-cadence
Copy link
Contributor Author

@yongwww can you please merge this, Thanks.

@masahi masahi merged commit 5cf3405 into apache:main Feb 9, 2023
@balaram-cadence balaram-cadence deleted the cadence/balaram/selectv2_bugfix branch February 9, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Frontend][Tensorflow] tf.where with broadcast condition fails to import due to Incompatible broadcast type

4 participants