[TIR] Use IRModuleNode::Remove to remove None in PrimFuncPass #14494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `PrimFuncPass` directly removed empty `PrimFunc` objects from the module's `Map<GlobalVar, BaseFunc> functions`. Because it didn't update the `global_var_map_` as well, these two maps could become out of sync. Since the `global_var_map_` is checked as part of `StructuralEqual()`, but isn't displayed when printing to TVMScript, this can result in identical printouts being flagged as non-identical. This commit updates `PrimFuncPass` to call the `IRModuleNode::Remove` method, which updates both the `functions` and `global_var_map_` variables.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
kparzysz-quic
approved these changes
Apr 4, 2023
Hzfengsy
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
PrimFuncPassdirectly removed emptyPrimFuncobjects from the module'sMap<GlobalVar, BaseFunc> functions. Because it didn't update theglobal_var_map_as well, these two maps could become out of sync. Since theglobal_var_map_is checked as part ofStructuralEqual(), but isn't displayed when printing to TVMScript, this can result in identical printouts being flagged as non-identical.This commit updates
PrimFuncPassto call theIRModuleNode::Removemethod, which updates both thefunctionsandglobal_var_map_variables.This is part of changes described in #14486, to improve round-trip failures that occur in lowering.